This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Unhandled Error on Copy & Paste - Refactor Copy | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | John Rice <jrice> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | proposed patch |
Description
John Rice
2008-01-21 14:18:27 UTC
I am having difficulty reproducing this. I saw it once but have not been able to reproduce it. *** Issue 125621 has been marked as a duplicate of this issue. *** Still intermittent. I am seeing we are in hgMoveImplementation if MercurialInterceptor.java , moving Main_1.java to Main.java and the status of Main_1.java is reported as STATUS_VERSIONED_UPTODATE. This is wrong. I think that the following is happening: We get a notification of creation of Main_1.java so we call cache.refresh to update the status of the file. While this is happening we get notification that Main_1.java has moved to Main.java. We then call hgMoveImplementation and in there call FileStatuscache.getStatus for Main_1.java. As the cache.refresh call has not finished yet we do not get the correct status for the file. Created attachment 55360 [details]
proposed patch
The propsoed patch ensures that hgMoveImplementation makes the hg calls in the RequestProcessor thread so the hg calls are serialized. We also need to wait for hgMoveImplementation to complete before continuing. IDE:------------------------------------------------- IDE: [1/22/08 2:31 PM] Committing "Mercurial" started Checking in MercurialInterceptor.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/MercurialInterceptor.java,v <-- MercurialInterceptor.java new revision: 1.18; previous revision: 1.17 done Checking in Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/Bundle.properties,v <-- Bundle.properties new revision: 1.16; previous revision: 1.15 done IDE: [1/22/08 2:31 PM] Committing "Mercurial" finished |