This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Freeze while opening popup on project node | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | Jiri Skrivanek <jskrivanek> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Thread dump.
Proposed patch |
Description
Jiri Skrivanek
2008-01-14 14:48:54 UTC
Created attachment 55037 [details]
Thread dump.
Had a quick look at this using the profiler: HgUtils.readIgnoreEntries: 58ms MercurialAnnotator.getActions: 44ms HgUtils.addIgnorePatterns: 41ms The main/.hgignore has 763 entries. getActions() calls isNothingVersioned() calls getStatus() calls isIgnored() annotateName() calls getCachedStatus() calls isIgnored() Will need to look into optimizing this if possible Created attachment 55196 [details]
Proposed patch
Changing the logic in the menu enabling code, so for Clone, ExportDiff, ImportDiff, Log (Show History), Rollback and RevertModifications we used to call hasHistory in isEnabled(). We no longer do this but check that its under Hg control, then when they perform the action, if it has no history we inform the user and return. This removes all Hg related calls from menu display and speeds things up a lot. Also fixed a few inconsistencies when some top level menu items, namely Pull & Push to default where enabled for non Hg projects, that should not have been. IDE:------------------------------------------------- IDE: [17/01/08 13:12] Committing Files started Checking in ui/diff/ExportDiffAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/diff/ExportDiffAction.java,v <-- ExportDiffAction.java new revision: 1.10; previous revision: 1.9 done Checking in ui/diff/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/diff/Bundle.properties,v <-- Bundle.properties new revision: 1.9; previous revision: 1.8 done Checking in ui/diff/ImportDiffAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/diff/ImportDiffAction.java,v <-- ImportDiffAction.java new revision: 1.11; previous revision: 1.10 done Checking in ui/update/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/update/Bundle.properties,v <-- Bundle.properties new revision: 1.6; previous revision: 1.5 done Checking in ui/update/RevertModificationsAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/update/RevertModificationsAction.java,v <-- RevertModificationsAction.java new revision: 1.10; previous revision: 1.9 done Checking in ui/pull/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/pull/Bundle.properties,v <-- Bundle.properties new revision: 1.14; previous revision: 1.13 done Checking in ui/pull/PullAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/pull/PullAction.java,v <-- PullAction.java new revision: 1.21; previous revision: 1.20 done Checking in ui/clone/CloneAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/clone/CloneAction.java,v <-- CloneAction.java new revision: 1.18; previous revision: 1.17 done Checking in ui/clone/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/clone/Bundle.properties,v <-- Bundle.properties new revision: 1.16; previous revision: 1.15 done Checking in MercurialAnnotator.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/MercurialAnnotator.java,v <-- MercurialAnnotator.java new revision: 1.21; previous revision: 1.20 done Checking in ui/push/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/push/Bundle.properties,v <-- Bundle.properties new revision: 1.14; previous revision: 1.13 done Checking in ui/push/PushAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/push/PushAction.java,v <-- PushAction.java new revision: 1.22; previous revision: 1.21 done Checking in ui/log/LogAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/log/LogAction.java,v <-- LogAction.java new revision: 1.11; previous revision: 1.10 done Checking in ui/log/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/log/Bundle.properties,v <-- Bundle.properties new revision: 1.6; previous revision: 1.5 done Checking in ui/rollback/RollbackAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/rollback/RollbackAction.java,v <-- RollbackAction.java new revision: 1.12; previous revision: 1.11 done Checking in ui/merge/MergeAction.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/merge/MergeAction.java,v <-- MergeAction.java new revision: 1.13; previous revision: 1.12 done IDE: [17/01/08 13:12] Committing Files finished Verified. *** Issue 126843 has been marked as a duplicate of this issue. *** *** Issue 126869 has been marked as a duplicate of this issue. *** *** Issue 126978 has been marked as a duplicate of this issue. *** *** Issue 126877 has been marked as a duplicate of this issue. *** |