This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | refactoring a jsf fragment fails | ||
---|---|---|---|
Product: | obsolete | Reporter: | pepeio <pepeio> |
Component: | visualweb | Assignee: | _ sandipchitale <sandipchitale> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | blaha, non_migrated_user, pjiricka, ppisl |
Priority: | P2 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
pepeio
2007-11-21 11:10:22 UTC
According Bug guidelines document http://qa.netbeans.org/bugzilla/bug_priority_guidelines.html the issue is P2 then P1. Anyway, the bug should be fixed in next release or in some patch update. I wasn't able to reproduce this issue. Where did you see the exception? Here is how to reproduce the problem under NB6RC2: Create a web project, select visual web In your default page1.jsp, drop a "Page Fragment Box" on the page, click on "Create a new Page Fragment", give it 'Test' as the name. Now, in the projects tab, select the Test.jsp page, and rename it to TestFragment.jsp Press f6 and in your compile log you will see the stack dump Application will nevertheless be deployed. Now I understand. The problem is in the refactoring of the visual page. Reassigning. Hmmm...the refactoring is not handling the case of adjusting the relative path for fragment rename. Fragment move is working. The workwaround is to fix the path in JSP editor. Handle the case of inter page references in case of Rename refactoring. Also fixed handling of /faces/ prefix based references in case Move and Rename refactoring. Checking in src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJspFileMoveRefactoringPlugin.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJspFileMoveRefactoringPlugin.java,v <-- FacesJspFileMoveRefactoringPlugin.java new revision: 1.12; previous revision: 1.11 done Checking in src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJspFileRenameRefactoringPlugin.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJspFileRenameRefactoringPlugin.java,v <-- FacesJspFileRenameRefactoringPlugin.java new revision: 1.6; previous revision: 1.5 done Checking in src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesRefactoringUtils.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesRefactoringUtils.java,v <-- FacesRefactoringUtils.java new revision: 1.14; previous revision: 1.13 done Reporter, can you verify the fix in the latest daily build? Then, we can include the fix in next NB 6.0 patch. Thanks I followed the steps i previously described, which somewhat worked. ( tree node in navigator did not update and was showing old name). tThat seemed to be the only visible problem, but i cannot swear everything went fine internally (due to node not updating, mainly) I don't know if it's related to the refactoring but here it is anyway: Then, i added a table to the fragment, duplicated the fragment on the page, compiled, ran, suppressed two of the three fragments i duplicated. ( me evil ;) ) Then i refactored the fragment. The table i added to the fragment started to show incomplete (no bar, ...). I got a NPE when i tried to remove table. (pressing suppr key). Here is the issue: http://statistics.netbeans.org/analytics/detail.do?id=8615 Reporter, can you file separate issue on the Navigator issue as well as submit another report against the NPE http://statistics.netbeans.org/analytics/detail.do?id=8615. I did duplicate the the Navigator issue but not the NPE, so it would be ideal to have repeatable steps. Otherwise, the main issue of refactoring the fragment from the project node has been fixed and runtime no longer produces the jasper exception. Navigator issue got sent: http://www.netbeans.org/issues/show_bug.cgi?id=124934 i am waiting for the possibility to test extensively the NPE before sending it. Fixed. Thank you, pepeio, for filing the bug! Verifying fixed refactoring jsf fragment: Trunk NetBeans IDE Dev (Build 200801081200) Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19 System: Windows XP version 5.1 running on x86; Cp1252; en_US (nb) The fixes have been ported into the release601_fixes branch. Checking in FacesJspFileMoveRefactoringPlugin.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/Attic/FacesJspFileMoveRefactoringPlugin.java,v <-- FacesJspFileMoveRefactoringPlugin.java new revision: 1.11.10.1; previous revision: 1.11 done Checking in FacesJspFileRenameRefactoringPlugin.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/Attic/FacesJspFileRenameRefactoringPlugin.java,v <-- FacesJspFileRenameRefactoringPlugin.java new revision: 1.5.10.1; previous revision: 1.5 done Checking in FacesRefactoringUtils.java; /cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/Attic/FacesRefactoringUtils.java,v <-- FacesRefactoringUtils.java new revision: 1.13.6.1; previous revision: 1.13 done |