This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Deadlock during writing in JSpEditor | ||
|---|---|---|---|
| Product: | javaee | Reporter: | Petr Pisl <ppisl> |
| Component: | JSP | Assignee: | Marek Fukala <mfukala> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | CC: | mschovanek, non_migrated_user, pjiricka |
| Priority: | P2 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: | Thea dealock. | ||
|
Description
Petr Pisl
2007-11-07 16:16:14 UTC
Created attachment 52667 [details]
Thea dealock.
This is my fault :-( I overlooked that the JspCompletionItem$JspCompletionItem.substituteText() calls JspCompletionItem$JspCompletionItem.reformat() method under document.atomicLock(). This breaks the paradigm Reformat.lock() firts, then Document.atomicLock(). So after Reformat.lock() is called the infrastructure calls java Reformatter.lock() which tries to get java compiler's lock. "Java Source Worked Thread" however holds the javac lock and tries to readLock() the document. Fixed by removing the JspCompletionItem$JspCompletionItem.reformat() call from the atomicLock block. The fix needs to be ported to 6.0 branch. BTW, html implementation is OK. fixed in trunk Checking in JspCompletionItem.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/completion/JspCompletionItem.java,v <-- JspCompletionItem.java new revision: 1.19; previous revision: 1.18 done Correction: JspCompletionItem$JspResultItem.* *** Issue 122436 has been marked as a duplicate of this issue. *** verified NetBeans IDE Dev (Build 200801310006) The fix has been ported into the release601_fixes branch. Checking in JspCompletionItem.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/completion/Attic/JspCompletionItem.java,v <-- JspCompletionItem.java new revision: 1.18.6.1; previous revision: 1.18 done |