This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 104145

Summary:	panelDeactivated not called when corresponding window is closed
Product:	platform	Reporter:	Peter Zavadsky <pzavadsky>
Component:	Navigator	Assignee:	David Simonek <dsimonek>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	deva, issues, quynguyen, sandipchitale
Priority:	P2	Keywords:	PERFORMANCE
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:	104229
Bug Blocks:	123530, 123003

Description Peter Zavadsky 2007-05-17 08:29:05 UTC

The case:
1) Open VW project,
2) The Page is opened and the designer tab is selected,
3) The outline inside navigator is provided
4) Go to project tab, and close the VW project
5) The designer gets closed
6) But the outline remains (its nodes are changed, but not because of
notifications from navigator.

It is expected that the panelDeactivated be called, which isn't.
It creates a memory leak in the outline (after closing the project) - missed the
cleaning in the panelDeactivated method.

Comment 1 Peter Zavadsky 2007-05-17 08:31:52 UTC

CC interested parties, also added PERFORMANCE keyword -> memory leak.

Comment 2 David Simonek 2007-08-16 21:52:01 UTC

I believe this is fixed along with the fix of 104229. Navigator now listen to node destroy, so it should update
correctly and call panelDeactivated.

Comment 3 Peter Zavadsky 2007-12-06 23:08:35 UTC

It is not fixed now, or it came back.

The scenario now. 
1) Open the VW project, 
2) open a designer, that opens the navigator and outline in it, and panelActivated is called
3) close the designer, that closes also the navigator, but panelDeactivated method is not called.

That causes memory leak.

Comment 4 Quy Nguyen 2008-01-14 23:04:06 UTC

This should be fixed for NB 6.1.  It causes a significant memory leak in visual web (~20 MB of memory on a project with
2 pages), so I am upgrading this to P2.

Comment 5 David Simonek 2008-01-16 15:57:42 UTC

working on it...

Comment 6 David Simonek 2008-01-17 11:35:44 UTC

fixed and test implemented:

Checking in test/unit/src/org/netbeans/modules/navigator/NavigatorTCTest.java;
/cvs/core/navigator/test/unit/src/org/netbeans/modules/navigator/NavigatorTCTest.java,v  <--  NavigatorTCTest.java
new revision: 1.17; previous revision: 1.16
done
Checking in test/unit/src/org/netbeans/modules/navigator/NavigatorControllerTest.java;
/cvs/core/navigator/test/unit/src/org/netbeans/modules/navigator/NavigatorControllerTest.java,v  <-- 
NavigatorControllerTest.java
new revision: 1.7; previous revision: 1.6
done
Checking in src/org/netbeans/modules/navigator/NavigatorController.java;
/cvs/core/navigator/src/org/netbeans/modules/navigator/NavigatorController.java,v  <--  NavigatorController.java
new revision: 1.37; previous revision: 1.36
done