This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Hide factory methods in VCSContext | ||
|---|---|---|---|
| Product: | versioncontrol | Reporter: | Maros Sandor <msandor> |
| Component: | Code | Assignee: | issues@versioncontrol <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | Keywords: | API_REVIEW_FAST |
| Priority: | P2 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
|
Description
Maros Sandor
2007-04-17 12:52:37 UTC
I am asking for the permission to keep the forNodes(Node[]) method in the SPI in some form (forLookup being an alternative). The method can also be in VersioningSupport class. I'll elaborate more: Clients are passed VCSContext when asked to annotate nodes or provide actions for them. So their Actions take VCSContext as argument and perform versioning actions on that context. However, there are other scenarios when clients use these actions. For example, in the CVS (Versioning) view, the table lists changed files and there are actions available on them via the popup menu. To simply re-use Actions for those menus clients would need to somehow create VCSContext out of nodes in the table. If clients are unable to create VCSContext they need to have TWO ways of providing input to every Ation, which is inconvenient. If there are no objections, I'll leave forNodes() method there as is. Closing. |