Please use the Apache issue tracking system for new NetBeans issues (https://issues.apache.org/jira/projects/NETBEANS0/issues) !!

Bug 258806

Summary: Implement Run/Debug launchers UI
Product: cnd Reporter: henk89
Component: ProjectAssignee: Alexander Simon <alexvsimon>
Status: RESOLVED FIXED QA Contact: issues <issues.netbeans.org>
Priority: P3    
Version: 8.2   
Target Milestone: 8.2   
Hardware: All   
OS: All   
Whiteboard:
Issue Type: DEFECT Exception Report:
Bug Depends on: 258837, 258843, 258852, 259009    
Bug Blocks: 229218    
Attachments: To demonstrate VV8: The current icons are bad (especially on dark L&F)

Description henk89 2016-04-13 11:26:20 UTC

    
Comment 1 Vladimir Voskresensky 2016-04-13 19:03:41 UTC
Alexander, great first version!
There are some problems with used color in Dark Theme

Also, could you put Launchers into project Properties dialog?
Comment 2 Vladimir Voskresensky 2016-04-14 00:26:26 UTC
Please, change icons to nicer (i.e. from navigator):
Suggestions:
private common - private constructor icon
public  common - public constructor icon
private launcher - private field icon
public  launcher - public field icon
Comment 3 Vladimir Voskresensky 2016-04-14 00:27:13 UTC
Btw, when checkbox "Private" changes state icon now doesn't change it's presentation
Comment 4 Vladimir Voskresensky 2016-04-14 00:27:59 UTC
VV3: Manager Launchers... shows nothing from Files view (works only from Projects view)
Comment 5 Vladimir Voskresensky 2016-04-14 00:29:24 UTC
(In reply to Vladimir Voskresensky from comment #3)
> Btw, when checkbox "Private" changes state icon now doesn't change it's
> presentation
VV2: I meant "Public launcher" checkbox doesn't affect icon
Comment 6 Vladimir Voskresensky 2016-04-14 00:31:08 UTC
VV4: it's worth to have tooltips.
I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
Comment 7 Vladimir Voskresensky 2016-04-14 00:32:26 UTC
VV5: Run Command uses control which is difficult to review/modify. It should be like script body in SendTo config panel
Comment 8 Vladimir Voskresensky 2016-04-14 00:34:13 UTC
VV6: Run Directory and Symbol Files should have "..." to choose directory/file in File Chooser
Comment 9 Quality Engineering 2016-04-14 02:40:51 UTC
Integrated into 'main-silver', will be available in build *201604140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4bff67a88bea
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI
Comment 10 Vladimir Voskresensky 2016-04-14 08:36:09 UTC
(In reply to Vladimir Voskresensky from comment #1)
> Alexander, great first version!
> There are some problems with used color in Dark Theme
> 
> Also, could you put Launchers into project Properties dialog?
I think, we can have in Project properties Launcher node on the left (in tree) and in Panel we can have just list of launchers with Up/Down + Manage... which will open the current dialog
Comment 11 Alexander Simon 2016-04-14 10:16:46 UTC
(In reply to Vladimir Voskresensky from comment #5)
> (In reply to Vladimir Voskresensky from comment #3)
> > Btw, when checkbox "Private" changes state icon now doesn't change it's
> > presentation
> VV2: I meant "Public launcher" checkbox doesn't affect icon
fixed in change set:
http://hg.netbeans.org/cnd-main/rev/b5ab4ae5c549
Comment 12 Alexander Simon 2016-04-14 11:00:23 UTC
(In reply to Vladimir Voskresensky from comment #4)
> VV3: Manager Launchers... shows nothing from Files view (works only from
> Projects view)

fixed, change set:
http://hg.netbeans.org/cnd-main/rev/852f5417ae72
Comment 13 Alexander Simon 2016-04-14 12:08:47 UTC
(In reply to Vladimir Voskresensky from comment #6)
> VV4: it's worth to have tooltips.
> I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro

fived, change set:
http://hg.netbeans.org/cnd-main/rev/322ec87fe45f
Comment 14 Alexander Simon 2016-04-14 13:35:30 UTC
(In reply to Vladimir Voskresensky from comment #7)
> VV5: Run Command uses control which is difficult to review/modify. It should
> be like script body in SendTo config panel

fixed, change set:
http://hg.netbeans.org/cnd-main/rev/0a278d6d9447
Comment 15 Vladimir Voskresensky 2016-04-14 14:06:52 UTC
(In reply to Alexander Simon from comment #13)
> (In reply to Vladimir Voskresensky from comment #6)
> > VV4: it's worth to have tooltips.
> > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> 
> fived, change set:
> http://hg.netbeans.org/cnd-main/rev/322ec87fe45f

VV7: please, add tooltip to controls as well (i.e. table, textbox), not to control lables only
Comment 16 Alexander Simon 2016-04-14 14:24:03 UTC
(In reply to Vladimir Voskresensky from comment #2)
> Please, change icons to nicer (i.e. from navigator):
> Suggestions:
> private common - private constructor icon
> public  common - public constructor icon
> private launcher - private field icon
> public  launcher - public field icon

Do not think that reusing code model icons is a good idea.
Do not fix.
Comment 17 Alexander Simon 2016-04-14 14:26:26 UTC
(In reply to Vladimir Voskresensky from comment #15)
> (In reply to Alexander Simon from comment #13)
> > (In reply to Vladimir Voskresensky from comment #6)
> > > VV4: it's worth to have tooltips.
> > > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> > 
> > fived, change set:
> > http://hg.netbeans.org/cnd-main/rev/322ec87fe45f
> 
> VV7: please, add tooltip to controls as well (i.e. table, textbox), not to
> control lables only

Do not think that it is a good idea. The tool tip on fields will disturb user to see field content. Do not fix.
Comment 18 Alexander Simon 2016-04-14 15:06:40 UTC
(In reply to Vladimir Voskresensky from comment #10)
> (In reply to Vladimir Voskresensky from comment #1)
> > Alexander, great first version!
> > There are some problems with used color in Dark Theme
> > 
> > Also, could you put Launchers into project Properties dialog?
> I think, we can have in Project properties Launcher node on the left (in
> tree) and in Panel we can have just list of launchers with Up/Down +
> Manage... which will open the current dialog

I do not think that it is a good idea. Or action in pop-up menu or node in project properties.
But anyway, fixed, change set:
http://hg.netbeans.org/cnd-main/rev/d9caf9c32cf2
Comment 19 Vladimir Voskresensky 2016-04-14 15:38:17 UTC
(In reply to Alexander Simon from comment #16)
> (In reply to Vladimir Voskresensky from comment #2)
> > Please, change icons to nicer (i.e. from navigator):
> > Suggestions:
> > private common - private constructor icon
> > public  common - public constructor icon
> > private launcher - private field icon
> > public  launcher - public field icon
> 
> Do not think that reusing code model icons is a good idea.
> Do not fix.
VV8: The current icons are bad (especially on dark L&F)
Please, choose any other public/private from existing ones
Comment 20 Vladimir Voskresensky 2016-04-14 15:38:39 UTC
(In reply to Alexander Simon from comment #17)
> (In reply to Vladimir Voskresensky from comment #15)
> > (In reply to Alexander Simon from comment #13)
> > > (In reply to Vladimir Voskresensky from comment #6)
> > > > VV4: it's worth to have tooltips.
> > > > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> > > 
> > > fived, change set:
> > > http://hg.netbeans.org/cnd-main/rev/322ec87fe45f
> > 
> > VV7: please, add tooltip to controls as well (i.e. table, textbox), not to
> > control lables only
> 
> Do not think that it is a good idea. The tool tip on fields will disturb
> user to see field content. Do not fix.
VV9: add it at least for env table
Comment 21 Vladimir Voskresensky 2016-04-14 15:50:21 UTC
(In reply to Vladimir Voskresensky from comment #19)
> (In reply to Alexander Simon from comment #16)
> > (In reply to Vladimir Voskresensky from comment #2)
> > > Please, change icons to nicer (i.e. from navigator):
> > > Suggestions:
> > > private common - private constructor icon
> > > public  common - public constructor icon
> > > private launcher - private field icon
> > > public  launcher - public field icon
> > 
> > Do not think that reusing code model icons is a good idea.
> > Do not fix.
> VV8: The current icons are bad (especially on dark L&F)
> Please, choose any other public/private from existing ones
As alternative you can use "Run Main Project" & "Run Project" icons
Comment 22 Alexander Simon 2016-04-14 16:48:13 UTC
(In reply to Vladimir Voskresensky from comment #8)
> VV6: Run Directory and Symbol Files should have "..." to choose
> directory/file in File Chooser

"Run File system" belongs to configuration. Project can have several configurations with different file systems. So impossible to create file chooser for unknown file system.
Do not fix.
Comment 23 Alexander Simon 2016-04-14 17:00:08 UTC
Created attachment 159273 [details]
To demonstrate VV8: The current icons are bad (especially on dark L&F)
Comment 24 Alexander Simon 2016-04-14 17:02:13 UTC
(In reply to Vladimir Voskresensky from comment #21)
> (In reply to Vladimir Voskresensky from comment #19)
> > (In reply to Alexander Simon from comment #16)
> > > (In reply to Vladimir Voskresensky from comment #2)
> > > > Please, change icons to nicer (i.e. from navigator):
> > > > Suggestions:
> > > > private common - private constructor icon
> > > > public  common - public constructor icon
> > > > private launcher - private field icon
> > > > public  launcher - public field icon
> > > 
> > > Do not think that reusing code model icons is a good idea.
> > > Do not fix.
> > VV8: The current icons are bad (especially on dark L&F)
> > Please, choose any other public/private from existing ones
> As alternative you can use "Run Main Project" & "Run Project" icons

I do not think that icons are bad (see comment #23)
Please move this topic in separate enchantment.
Comment 25 Vladimir Voskresensky 2016-04-14 17:32:08 UTC
(In reply to Alexander Simon from comment #24)
> (In reply to Vladimir Voskresensky from comment #21)
> > (In reply to Vladimir Voskresensky from comment #19)
> > > (In reply to Alexander Simon from comment #16)
> > > > (In reply to Vladimir Voskresensky from comment #2)
> > > > > Please, change icons to nicer (i.e. from navigator):
> > > > > Suggestions:
> > > > > private common - private constructor icon
> > > > > public  common - public constructor icon
> > > > > private launcher - private field icon
> > > > > public  launcher - public field icon
> > > > 
> > > > Do not think that reusing code model icons is a good idea.
> > > > Do not fix.
> > > VV8: The current icons are bad (especially on dark L&F)
> > > Please, choose any other public/private from existing ones
> > As alternative you can use "Run Main Project" & "Run Project" icons
> 
> I do not think that icons are bad (see comment #23)
> Please move this topic in separate enchantment.
I agree 
https://netbeans.org/bugzilla/show_bug.cgi?id=258837
Comment 26 Quality Engineering 2016-04-15 01:47:02 UTC
Integrated into 'main-silver', will be available in build *201604150001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c84c7e8d8cd1
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI
- fix icon in dark L&F
Comment 27 Quality Engineering 2016-04-16 01:50:36 UTC
Integrated into 'main-silver', will be available in build *201604160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a807a45dd3ae
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI
- beautifying icons
Comment 28 Quality Engineering 2016-04-26 15:27:52 UTC
Integrated into 'main-silver', will be available in build *201604261340* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/f15c475411fe
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: extra fix for #258806 - Implement Run/Debug launchers UI
- zero is a valid index for launcher; use constants instead of negatives with special meanings
By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo