--- a/keyring/src/org/netbeans/modules/keyring/kde/KWalletProvider.java Tue Feb 02 05:54:53 2010 +0100 +++ a/keyring/src/org/netbeans/modules/keyring/kde/KWalletProvider.java Tue Feb 02 20:09:38 2010 +0100 @@ -43,6 +43,7 @@ import java.io.IOException; import java.io.InputStreamReader; import java.text.MessageFormat; +import java.util.Arrays; import java.util.MissingResourceException; import java.util.logging.Level; import java.util.logging.Logger; @@ -129,7 +130,6 @@ } private char[] runCommand(String command,char[]... commandArgs){ - String commandString = "qdbus org.kde.kwalletd /modules/kwalletd org.kde.KWallet."+command; String[] argv = new String[commandArgs.length+4]; argv[0] = "qdbus"; argv[1] = "org.kde.kwalletd"; @@ -139,9 +139,6 @@ //unfortunatelly I cannot pass char[] to the exec in any way - so this poses a security issue with passwords in String() ! //TODO: find a way to avoid changing char[] into String argv[i+4] = new String(commandArgs[i]); - char[] arg = commandArgs[i]; - String string = new String(arg); - commandString = commandString+" "+string; } Runtime rt = Runtime.getRuntime(); @@ -173,16 +170,16 @@ int exitVal = pr.waitFor(); if(exitVal!=0){ - logger.log(Level.SEVERE,"application exit with code "+exitVal+" for commandString: "+commandString); + logger.log(Level.SEVERE,"application exit with code "+exitVal+" for commandString: "+Arrays.toString(argv)); } } catch (InterruptedException ex) { logger.log(Level.SEVERE, - "exception thrown while invoking the command \""+commandString+"\"", + "exception thrown while invoking the command \""+Arrays.toString(argv)+"\"", ex); } catch (IOException ex) { logger.log(Level.SEVERE, - "exception thrown while invoking the command \""+commandString+"\"", + "exception thrown while invoking the command \""+Arrays.toString(argv)+"\"", ex); } return (!retVal.equals("")) ? retVal.trim().toCharArray() : null; @@ -193,7 +190,7 @@ try { appName = MessageFormat.format(NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),"…"); } catch (MissingResourceException x) { - appName = "NetBeans"; + appName = "NetBeans"; } return appName.toCharArray(); }