This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

View | Details | Raw Unified | Return to bug 220294
Collapse All | Expand All

(-)a/openide.filesystems/src/org/openide/filesystems/FileUtil.java (-2 / +11 lines)
Lines 44-49 Link Here
44
44
45
package org.openide.filesystems;
45
package org.openide.filesystems;
46
46
47
import java.awt.EventQueue;
47
import java.io.File;
48
import java.io.File;
48
import java.io.FileFilter;
49
import java.io.FileFilter;
49
import java.io.FilenameFilter;
50
import java.io.FilenameFilter;
Lines 89-94 Link Here
89
import org.openide.util.NbBundle;
90
import org.openide.util.NbBundle;
90
import org.openide.util.Parameters;
91
import org.openide.util.Parameters;
91
import org.openide.util.RequestProcessor;
92
import org.openide.util.RequestProcessor;
93
import org.openide.util.StackElementArray;
92
import org.openide.util.Utilities;
94
import org.openide.util.Utilities;
93
import org.openide.util.WeakListeners;
95
import org.openide.util.WeakListeners;
94
import org.openide.util.lookup.implspi.NamedServicesProvider;
96
import org.openide.util.lookup.implspi.NamedServicesProvider;
Lines 112-117 Link Here
112
    * of type Set<String>
114
    * of type Set<String>
113
    */
115
    */
114
    static final Set<String> transientAttributes = new HashSet<String>();
116
    static final Set<String> transientAttributes = new HashSet<String>();
117
    
118
    private static boolean asserts = false;
119
    private static final Set<StackElementArray> stacks;
115
120
116
    static {
121
    static {
117
        transientAttributes.add("templateWizardURL"); // NOI18N
122
        transientAttributes.add("templateWizardURL"); // NOI18N
Lines 127-132 Link Here
127
        transientAttributes.add("iconBase"); // NOI18N
132
        transientAttributes.add("iconBase"); // NOI18N
128
        transientAttributes.add("position"); // NOI18N
133
        transientAttributes.add("position"); // NOI18N
129
        transientAttributes.add(MultiFileObject.WEIGHT_ATTRIBUTE); // NOI18N
134
        transientAttributes.add(MultiFileObject.WEIGHT_ATTRIBUTE); // NOI18N
135
        
136
        assert asserts = true;
137
        stacks = asserts ? StackElementArray.createSet() : null;
130
    }
138
    }
131
139
132
    /** Cache for {@link #isArchiveFile(FileObject)}. */
140
    /** Cache for {@link #isArchiveFile(FileObject)}. */
Lines 854-861 Link Here
854
        if(file.getPath().equals("\\\\")) {
862
        if(file.getPath().equals("\\\\")) {
855
            return null;
863
            return null;
856
        }
864
        }
857
        boolean asserts = false;
858
        assert asserts = true;
859
        if (asserts) {
865
        if (asserts) {
860
            File normFile = normalizeFile(file);
866
            File normFile = normalizeFile(file);
861
            if (!file.equals(normFile)) {
867
            if (!file.equals(normFile)) {
Lines 1587-1592 Link Here
1587
    private static File normalizeFileImpl(File file) {
1593
    private static File normalizeFileImpl(File file) {
1588
        // XXX should use NIO in JDK 7; see #6358641
1594
        // XXX should use NIO in JDK 7; see #6358641
1589
        Parameters.notNull("file", file);  //NOI18N
1595
        Parameters.notNull("file", file);  //NOI18N
1596
        if (asserts && EventQueue.isDispatchThread() && StackElementArray.addStackIfNew(stacks, 8)) {
1597
            LOG.log(Level.WARNING, "FileUtil.normalizeFile(" + file +") called in EDT", new Exception());
1598
        }
1590
        File retFile;
1599
        File retFile;
1591
        LOG.log(Level.FINE, "FileUtil.normalizeFile for {0}", file); // NOI18N
1600
        LOG.log(Level.FINE, "FileUtil.normalizeFile for {0}", file); // NOI18N
1592
1601
(-)a/openide.util/src/org/openide/util/StackElementArray.java (+120 lines)
Line 0 Link Here
1
/*
2
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
3
 *
4
 * Copyright 2013 Oracle and/or its affiliates. All rights reserved.
5
 *
6
 * Oracle and Java are registered trademarks of Oracle and/or its affiliates.
7
 * Other names may be trademarks of their respective owners.
8
 *
9
 * The contents of this file are subject to the terms of either the GNU
10
 * General Public License Version 2 only ("GPL") or the Common
11
 * Development and Distribution License("CDDL") (collectively, the
12
 * "License"). You may not use this file except in compliance with the
13
 * License. You can obtain a copy of the License at
14
 * http://www.netbeans.org/cddl-gplv2.html
15
 * or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
16
 * specific language governing permissions and limitations under the
17
 * License.  When distributing the software, include this License Header
18
 * Notice in each file and include the License file at
19
 * nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
20
 * particular file as subject to the "Classpath" exception as provided
21
 * by Oracle in the GPL Version 2 section of the License file that
22
 * accompanied this code. If applicable, add the following below the
23
 * License Header, with the fields enclosed by brackets [] replaced by
24
 * your own identifying information:
25
 * "Portions Copyrighted [year] [name of copyright owner]"
26
 *
27
 * If you wish your version of this file to be governed by only the CDDL
28
 * or only the GPL Version 2, indicate your decision by adding
29
 * "[Contributor] elects to include this software in this distribution
30
 * under the [CDDL or GPL Version 2] license." If you do not indicate a
31
 * single choice of license, a recipient has the option to distribute
32
 * your version of this file under either the CDDL, the GPL Version 2 or
33
 * to extend the choice of license to its licensees as provided above.
34
 * However, if you add GPL Version 2 code and therefore, elected the GPL
35
 * Version 2 license, then the option applies only if the new code is
36
 * made subject to such option by the copyright holder.
37
 *
38
 * Contributor(s):
39
 *
40
 * Portions Copyrighted 2013 Sun Microsystems, Inc.
41
 */
42
package org.openide.util;
43
44
import java.util.Collections;
45
import java.util.HashSet;
46
import java.util.Set;
47
48
/**
49
 * Array of stack trace elements may be used for logging of unique stack traces only
50
 * (for frequent problematic code invocations).
51
 *
52
 * @author Miloslav Metelka
53
 */
54
public class StackElementArray {
55
56
    public static Set<StackElementArray> createSet() {
57
        return Collections.synchronizedSet(new HashSet<StackElementArray>());
58
    }
59
60
    public static boolean addStackIfNew(Set<StackElementArray> stacks, int stackCompareSize) {
61
        StackTraceElement[] stackElems = new Exception().getStackTrace();
62
        int startIndex = 2; // For faster comparison cut of first two (this method and the caller's place)
63
        int endIndex = Math.min(stackElems.length, startIndex + stackCompareSize);
64
        StackTraceElement[] compareElems = new StackTraceElement[endIndex - startIndex];
65
        System.arraycopy(stackElems, startIndex, compareElems, 0, endIndex - startIndex);
66
        StackElementArray stackElementArray = new StackElementArray(compareElems);
67
        if (!stacks.contains(stackElementArray)) {
68
            stacks.add(stackElementArray);
69
            return true;
70
        }
71
        return false;
72
    }
73
74
    private final StackTraceElement[] stackTrace;
75
76
    private final int hashCode;
77
78
    private StackElementArray(StackTraceElement[] stackTrace) {
79
        this.stackTrace = stackTrace;
80
        int hc = 0;
81
        for (StackTraceElement stackTrace1 : stackTrace) {
82
            hc ^= stackTrace1.hashCode();
83
        }
84
        hashCode = hc;
85
    }
86
87
    int length() {
88
        return stackTrace.length;
89
    }
90
91
    StackTraceElement element(int i) {
92
        return stackTrace[i];
93
    }
94
95
    @Override
96
    public int hashCode() {
97
        return hashCode;
98
    }
99
100
    @Override
101
    public boolean equals(Object obj) {
102
        if (obj == this) {
103
            return true;
104
        }
105
        if (!(obj instanceof StackElementArray)) {
106
            return false;
107
        }
108
        StackElementArray sea = (StackElementArray) obj;
109
        if (sea.length() != length()) {
110
            return false;
111
        }
112
        for (int i = 0; i < stackTrace.length; i++) {
113
            if (!element(i).equals(sea.element(i))) {
114
                return false;
115
            }
116
        }
117
        return true;
118
    }
119
120
}

Return to bug 220294