diff --git a/api.debugger.jpda/apichanges.xml b/api.debugger.jpda/apichanges.xml --- a/api.debugger.jpda/apichanges.xml +++ b/api.debugger.jpda/apichanges.xml @@ -786,6 +786,25 @@ + + + JPDABreakpoint with protected constructor. + + + + + + JPDABreakpoint class needs to be overriden by visual debugger breakpoints + to reuse it's functionality. All JPDA breakpoint implementation classes + extend the JPDABreakpoint class. Therefore we need the protected + constructor to be able to extend it by visual breakpoint implementaion + in debugger.jpda.visual module. + Public getSession() and setSession() methods introduced as well, + they are used by debugger.jpda module already. + + + + diff --git a/api.debugger.jpda/manifest.mf b/api.debugger.jpda/manifest.mf --- a/api.debugger.jpda/manifest.mf +++ b/api.debugger.jpda/manifest.mf @@ -1,6 +1,6 @@ Manifest-Version: 1.0 OpenIDE-Module: org.netbeans.api.debugger.jpda/2 OpenIDE-Module-Localizing-Bundle: org/netbeans/api/debugger/jpda/Bundle.properties -OpenIDE-Module-Specification-Version: 2.32 +OpenIDE-Module-Specification-Version: 2.33 OpenIDE-Module-Package-Dependencies: com.sun.jdi[VirtualMachineManager] diff --git a/api.debugger.jpda/src/org/netbeans/api/debugger/jpda/JPDABreakpoint.java b/api.debugger.jpda/src/org/netbeans/api/debugger/jpda/JPDABreakpoint.java --- a/api.debugger.jpda/src/org/netbeans/api/debugger/jpda/JPDABreakpoint.java +++ b/api.debugger.jpda/src/org/netbeans/api/debugger/jpda/JPDABreakpoint.java @@ -114,7 +114,7 @@ private List engines = new ArrayList(); - JPDABreakpoint () { + protected JPDABreakpoint () { Preferences preferences = NbPreferences.forModule(getClass()).node("debugging"); // NOI18N int num = preferences.getInt("default.suspend.action", -1); // NOI18N [TODO] create property name constant, use it in ActionsPanel if (num == -1) { @@ -247,8 +247,7 @@ * * @param session the specific session */ - // TODO: make this public API - synchronized void setSession(JPDADebugger session) { + public synchronized void setSession(JPDADebugger session) { this.session = session; } @@ -259,8 +258,7 @@ * * @return the specific session or null. */ - // TODO: make this public API - synchronized JPDADebugger getSession() { + public synchronized JPDADebugger getSession() { return session; } @@ -291,7 +289,7 @@ * * @param event a event to be fired */ - void fireJPDABreakpointChange (JPDABreakpointEvent event) { + protected void fireJPDABreakpointChange (JPDABreakpointEvent event) { Iterator i = new HashSet(breakpointListeners).iterator(); while (i.hasNext ()) @@ -320,7 +318,7 @@ } } - static void fillFilesForClass(String className, List files) { + protected static void fillFilesForClass(String className, List files) { int simpleNameIndex = className.lastIndexOf('.'); int innerClassIndex = className.indexOf('$'); if (innerClassIndex > 0) {