This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

View | Details | Raw Unified | Return to bug 194592
Collapse All | Expand All

(-)refactoring.java/src/org/netbeans/modules/refactoring/java/plugins/ChangeParametersPlugin.java (+22 lines)
Lines 46-51 Link Here
46
import com.sun.source.tree.VariableTree;
46
import com.sun.source.tree.VariableTree;
47
import com.sun.source.util.TreeScanner;
47
import com.sun.source.util.TreeScanner;
48
import java.io.IOException;
48
import java.io.IOException;
49
import java.nio.CharBuffer;
49
import java.text.MessageFormat;
50
import java.text.MessageFormat;
50
import java.util.*;
51
import java.util.*;
51
import javax.lang.model.element.*;
52
import javax.lang.model.element.*;
Lines 126-133 Link Here
126
            };
127
            };
127
128
128
            if (scanner.scan(javac.getTrees().getTree(method), s)) {
129
            if (scanner.scan(javac.getTrees().getTree(method), s)) {
130
                if (!isParameterBeingRemoved(method, s, paramTable)) {
129
                p = createProblem(p, true, NbBundle.getMessage(ChangeParametersPlugin.class, "ERR_NameAlreadyUsed", s));
131
                p = createProblem(p, true, NbBundle.getMessage(ChangeParametersPlugin.class, "ERR_NameAlreadyUsed", s));
130
            }
132
            }
133
            }
131
134
132
135
133
            // check parameter type
136
            // check parameter type
Lines 150-155 Link Here
150
        return p;    
153
        return p;    
151
    }
154
    }
152
155
156
    private boolean isParameterBeingRemoved(ExecutableElement method, String s, ParameterInfo[] paramTable) {
157
        boolean beingRemoved = false;
158
        for (int j = 0; j < method.getParameters().size(); j++) {
159
            VariableElement variable = method.getParameters().get(j);
160
            if (variable.getSimpleName().contentEquals(s)) {
161
162
                boolean isInNewList = false;
163
                for (ParameterInfo parameterInfo : paramTable) {
164
                    if (parameterInfo.getOriginalIndex() == j) {
165
                        isInNewList = true;
166
                    }
167
                }
168
                beingRemoved = !isInNewList;
169
                break;
170
            }
171
        }
172
        return beingRemoved;
173
    }
174
153
    private static String newParMessage(String par) {
175
    private static String newParMessage(String par) {
154
        return new MessageFormat(
176
        return new MessageFormat(
155
                getString("ERR_newpar")).format(new Object[] { getString(par) } // NOI18N
177
                getString("ERR_newpar")).format(new Object[] { getString(par) } // NOI18N

Return to bug 194592