This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 8007 - [40cat] Bookmarks are not saved.
Summary: [40cat] Bookmarks are not saved.
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Hints & Annotations (show other bugs)
Version: 3.x
Hardware: All All
: P2 enhancement with 9 votes (vote)
Assignee: Miloslav Metelka
URL:
Keywords:
: 48416 (view as bug list)
Depends on:
Blocks:
 
Reported: 2000-10-25 08:15 UTC by Jan Lahoda
Modified: 2007-11-05 13:39 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff of the editor changes (10.14 KB, patch)
2004-10-28 22:47 UTC, Miloslav Metelka
Details | Diff
Diff of the changes in openide (5.32 KB, patch)
2004-10-28 22:48 UTC, Miloslav Metelka
Details | Diff
Current incomplete solution (26.72 KB, patch)
2004-11-05 16:01 UTC, Miloslav Metelka
Details | Diff
Schema file (1.02 KB, text/plain)
2004-11-05 16:08 UTC, Miloslav Metelka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2000-10-25 08:15:11 UTC
Try to set bookmark and exit IDE. After next start, there will be no bookmark.
boston[1130].
Comment 1 Petr Nejedly 2000-10-25 09:37:59 UTC
This is not a bug, but rather not-yet implemented feature.
We have it on our ToDo list.
I'm marking it as enhancement.
Comment 2 Jan Lahoda 2001-01-24 15:37:59 UTC
Only changed version to Development.
Comment 3 Jan Chalupa 2001-05-05 21:54:51 UTC
Target milestone -> 3.3
Comment 4 David Konecny 2001-05-22 15:51:28 UTC
Changing the state of the issue to ASSIGNED, because it was cover in 
Requirements document at http://editor.netbeans.org/doc/Requirements.html
Comment 5 Jan Chalupa 2001-11-27 12:27:47 UTC
Target milestone -> 3.3.1.
Comment 6 Marek Grummich 2002-07-22 10:03:06 UTC
Set target milestone to TBD
Comment 7 Marek Grummich 2002-07-22 10:09:12 UTC
Set target milestone to TBD
Comment 8 Petr Slegr 2003-06-12 02:13:57 UTC
I am increasing priority because this issues is here for 
more than 2 years...and it is VERY VERY annoying...
Comment 9 bartholomew 2003-06-12 13:34:27 UTC
Heck!!!  I can't believe that after all this time this 
issue is still open.  I can't believe it was scheduled for 
3.3 which was released about 2 years ago.  Erm, is it 
really cheeky to increase the priority again?
Comment 10 Milan Kubec 2003-09-12 10:47:17 UTC
I think that now we should clearly consider this issue as DEFECT.
Comment 11 Milan Kubec 2003-09-12 10:56:41 UTC
Bookmarks are not restored after reopening the file too.
Comment 12 Miloslav Metelka 2004-01-23 12:43:05 UTC
I respect and agree with fix-in-36 as this is really long-standing
issue. Although I'm optimistic we may eventually postpone it to promoD
if we get out of time. Assigning to Dusan preliminarily.
Comment 13 pfelenda 2004-09-06 14:25:19 UTC
*** Issue 48416 has been marked as a duplicate of this issue. ***
Comment 14 Miloslav Metelka 2004-10-06 15:19:11 UTC
NB4.0 solution:
For all the files opened prior to IDE shutdown the bookmarks will be
written into an xml file and restored once the IDE opens up.
If the file gets closed and then reopened the bookmarks for that file
will not be remembered. This will prevent performance problems
resulting from accumulating of the bookmarks in the xml file.

Post-NB4.0 solution:
Create a bookmark manager dialog with visual representation of each
bookmark and respective operations such as clear-all etc.
Comment 15 gholmer 2004-10-06 15:33:39 UTC
This sounds perfect to me, and would save me a lot of time.
Comment 16 thunderjon 2004-10-06 16:31:58 UTC
To consider: If the file is modified outside of the specific 
NetBeans, the bookmark should be lost or correctly follow to correct 
line (maybe by calculating a hash of the line?). I would just like to 
see avoided the use case wher I book marked lines 100 and 200, but 
after adding 20 lines at 50-70 the bookmarks are shifted to incorrect 
positions.
Comment 17 Miloslav Metelka 2004-10-06 17:41:02 UTC
Yes, I agree. However this is IMHO a more generic problem that applies
in fact to all annotations throughout the document e.g. breakpoints.
Therefore it should be solved separately and the solution should be
applied to all the annotations.
Comment 18 Miloslav Metelka 2004-10-28 22:46:51 UTC
I have a fix for this issue but besides the editor it involves the
openide as well - it requires the bookmarks to be serialized as part
of the CloneableEditor serialization by using "persistentData"
document's property. I have consulted the change with Yarda and as
it's in fact a friend API creaton I kindly ask the DevRev team members
to review the change (I think that the fasttrack should be appropriate
here).
 I have modified the arch documents for both openide and editor
appropriately and I've added a test for the property serialization
into CloneableEditorSupport. I'm raising priority of the issue - it
needs to be integrated into 4.0.
Comment 19 Miloslav Metelka 2004-10-28 22:47:43 UTC
Created attachment 18588 [details]
Diff of the editor changes
Comment 20 Miloslav Metelka 2004-10-28 22:48:28 UTC
Created attachment 18589 [details]
Diff of the changes in openide
Comment 21 Miloslav Metelka 2004-10-28 22:50:28 UTC
Apologies - in my previous note the 'CloneableEditorSupport' should be
'CloneableEditorTest'.
Comment 22 Jesse Glick 2004-10-28 23:35:36 UTC
I would suggest a completely different fix. Storing such data in the
editor TC is not ideal because if you close the editor window, the TC
gets removed and your bookmarks are lost. Also the proposed API
involves new use of Java serialization, which is not desirable.

Prefer for the editor to directly associate the bookmarks with the
FileObject, either

1. Using file attributes - these go into $userdir/var/attributes.xml I
think. Not necessarily scalable to large number of files, I guess.

2. Using AuxiliaryConfiguration (private mode), in case the file is
part of a project (perhaps falling back to file attributes otherwise).
Has the advantage that the bookmark info lives or dies as part of the
nbproject/private/ dir, which is probably good.

Either of these options can be implemented without any API changes;
the APIs already exist.
Comment 23 Miloslav Metelka 2004-10-29 11:12:44 UTC
Jesse, I do not consider the proposed fix as a final solution (please
see one of the previous note - the one containing 'NB4.0 solution').

BTW originally I had another version of the fix worked out. I was
storing the bookmarks of the currently opened editors into an xml file
prior the shutdown. The problem was that if the IDE would get
restarted and some of the previously opened editor tabs would not get
clicked then the physical editors would not get created so during the
next IDE shutdown the bookmarks for these tabs would get lost.

Regarding your proposed solutions there are some additional questions
of how the final bookmark support should look like:

1) Do we want the bookmarks to be global or project-specific?

2) Do we want the bookmarks to be organized by some sort of bookmark
manager that would e.g. define the order of jumping through the
bokmarks or allow all the bookmarks to be discarded at once?

Regarding solution for 4.0 we did not plan to do any additional UI
changes (e.g. the bookmark manager dialog) so we need to avoid
accumulation of the bookmarks for many files.
Regarding your second proposed solution it depends on 1) which was not
decided yet and IMHO it would be better to make the decission when
doing the final solution for the bookmarks support.
 Regarding the binary serialization I do not see it so problematic for
this particular thing because there should be little or no intent to
modify the information externally by hand and if the information gets
lost it's not a serious data loss.
Comment 24 Jesse Glick 2004-10-29 15:22:44 UTC
"Do we want the bookmarks to be global or project-specific?" - what's
the difference? You have a file, you want to save some bookmarks for
it. The only question is where. private.xml is the best choice, I
think. E.g.

<editor-bookmarks xmlns="http://www.netbeans.org/ns/editor-bookmarks/1">
    <file>
        <!-- If relative to prj dir: -->
        <url>src/pkg/Clazz.java</url>
        <!-- Otherwise:
        <url>file:/home/sources/foo/pkg/Clazz.java</url>
        -->
        <line>38</line>
        <line>111</line>
        <line>129</line>
        <!-- ... -->
    </file>
    <!-- ... -->
</editor-bookmarks>

You can if you wish clean up "stale" bookmarks there, by checking for
nonexistent files; either every time you load the bookmark list for a
project, or whenever you write to it, etc.

For projectless files, either use attributes.xml, or just don't save
bookmarks at all - no big deal.

Keep it simple and just save the bookmark when it is created - then
you don't need to worry about hidden editor tabs etc.

Re. bookmarks manager - ack, why introduce a new dialog to do
something no one has asked for? Just save the bookmarks the user set
and do it quietly.
Comment 25 klosels 2004-10-29 16:06:58 UTC
I don't bother too much about how this is implemented, BUT:

The power of bookmarks for me lies in the simplicity of how they work. 

If you ever intend to create a "bookmark manager" (which we don't need
IMHO) or named bookmarks and such - make sure they still work like
they do now without further user invention: e.g. jumping between
bookmarks is linear through the file, regardless of the order in which
they were created; no enforcement to do anything but press Ctrl+F2 to
toggle.

I would very much prefer to have bookmarks saved in a project-specific
way if a file was opened through a project. Not saving bookmarks for
non-project files would be tolerable IMO.
Comment 26 Miloslav Metelka 2004-10-29 17:15:01 UTC
Ad bookmarks manager: I would personally like to have it but I can
live without it as well. I was thinking in a way of advantages that it
could bring e.g. a not-yet-opened file could be opened by choosing the
particular bookmark from the manager or e.g. the manager could also
help to keep manageable number of bookmarks etc. For example Vim's 
marks work similar to this and there is sort of bookmark manager by
doing ":marks".

Regarding private.xml I think it's a good choice partly because it
should "distribute" the marks among projects so there should be a
controllable amount of them per project.

Regarding cleaning of stale marks IMHO it would be better to clean
after a change in bookmarks to not slow down the file opening when the
bookmarks would be read from the xml. 

I don't like the private.xml/attributes.xml for project/non-project
files duality too much but there's probably nothing better right now.
To be precise we should probably check the attributes.xml as well for
the case when a non-project file could become project-based and
"transfer" the marks into private.xml and clear them in the
attributes.xml. If the project-based file would become project-less
it's probably OK to abandon the marks. But there's still an issue with
cleaning up stale bookmarks from project-less files (although there
should not be many). So for this promotion I would not save the
bookmarks for the project-less files.

So if there's a consensus I can implement the solution with storing
into the private.xml.
Comment 27 _ rkubacki 2004-10-29 17:45:37 UTC
I do not like an idea of bookmark manager. Too much work and
questionable result. We could live w/o it for a long time. F2
navigates through bookmarks in one file, CTRL+F2 toggls bookmark. No
tricks how to jump between file.

Re persistence: bookmarks for projectless files can be quite
legitimate for platform sources. But perhaps we can persist only
project specific ones. Saving on project/IDE close can be sufficient -
only bookmarks for currently opened files are stored and it is not
neceseary to check for stale items and they can survive editor close &
reopen within one session.
Comment 28 Miloslav Metelka 2004-11-01 09:46:19 UTC
Radime, as I have already mentioned saving of the bookmarks just for
the opened files is complicated by the case when you 
1) Open file A and put a bookmark into it.
2) Open file B and put a bookmark into it.
3) Restart IDE.
4) File B is active; Tab exists for TopComponent A but the whole data
for A only exist in a binary serialized form.
5) Shutdown IDE. Now bookmarks for the opened files should be
collected including file A which is opened from the user's point of
view as there is a tab for it. I'm not aware of any way of how to grab
the bookmark data for tab A in this state. IMHO it's not desirable to
force deserialization for not-yet-deserialized tabs as it would slow
down the shutdown. There could be a semi-precise approach to retain
the bookmarks by using the top components' names but I do not consider
this to be a solution.
 The original approach that I've presented was able to deal with this
problematic case as it serialized the bookmark data into the top
components' serialized data.
 So I would rather save all (not just for opened files) but I'm still
wondering when to save and when to eliminate stale bookmarks. Ideally
save upon change i.e. after bookmark toggling but I'm wondering
whether it does not become slow for many bookmarks (I'll test that).
Regarding stale bookmarks those could be checked during shutdown IMHO.
Comment 29 Miloslav Metelka 2004-11-01 14:44:37 UTC
BTW storing into private.xml will require the editor to depend on the
Project API. There is already a dependency because of "Goto Class"
functionality (see issue #50821) but that one is purely java-related
thing while the bookmarks should work globally for all mime-types. So
ideally we should separate the bookmarks support into a separate
editor's submodule ASAP.
Comment 30 _ rkubacki 2004-11-02 12:37:14 UTC
I see, opened but not activated component is a problem. OK, I do not
insist on my proposal.
Comment 31 Miloslav Metelka 2004-11-05 15:42:23 UTC
I now have a working solution of storing bookmarks into private.xml
except four things that I need to complete:
1) I don't know where should I put the a local .xsd file. I have
src/www/www/ns/editor-bookmarks/1.xsd but it should be accessible
locally as well by using schemaLocation parser property (right now I'm
using hardcoded local path temporarily). I guess I'm depending on
issue #42686 here which is not implemented yet and is planned for
promoE. Jesse is there any other way to accomplish this?

2) relativizing of the paths against the project folder. I thought
that I could use a generic URI.relativize() but it did not worked well
so I'll attempt to use FileUtil.getRelativePath() instead.

3) Excluding of the stale bookmarks (for no longer existing files).

4) Testing of how the solution scales with large number of bookmarks.

Anyway even if 1) would not be a stopper it is IMHO too risky to
integrate this completely new code into the NB4.0 release40 branch.
Therefore I would like to ask for waiver for 4.0. Instead I would put
the solution into the trunk and once we'll be sure that it behaves
well we would put it into an update of 4.0.
Comment 32 Miloslav Metelka 2004-11-05 16:01:18 UTC
Created attachment 18755 [details]
Current incomplete solution
Comment 33 Miloslav Metelka 2004-11-05 16:08:55 UTC
Created attachment 18756 [details]
Schema file
Comment 34 Jesse Glick 2004-11-06 02:09:06 UTC
Re. local copy of the schema - yes, #42686 would be required; nothing
to do for now, just publish it for reference if you integrate the patch.

What went wrong with URI.relativize?

FWIW I agree it would be a poor idea to push this into 4.0 now.
Whether you consider it an enhancement or a defect is a matter of
opinion, but it is certainly new functionality that was never planned
for before.

The schema specifies the wrong target namespace; it would I think
reject any actual private.xml if you really tried to validate using it
(did you?). Anyway the schema implies that you can have only one
<file> in your private.xml, which makes no sense to me. You seem to
have omitted any mention of the <editor-bookmarks> element.

static final String EDITOR_BOOKMARKS_NAMESPACE_URI =
"file:///usr/local/src/nb/t/www/www/ns/editor-bookmarks/1";

is clearly wrong!

Patch generally looks OK to me; didn't read all of it.
Comment 35 Miloslav Metelka 2004-11-08 17:27:03 UTC
Jesse, thanks for clarification.
I did not validated against the attached .xsd yet until today and I
had to fix it (added editor-bookmarks element and
maxOccurs="unbounded" for the file element). I've fixed missing
namespace adding into file and underlying elements as well (was
resulting in xmlns="" being added to file element).

> What went wrong with URI.relativize?
Apologies, I now know what was wrong - I was getting an exception
"java.lang.IllegalArgumentException: URI is not absolute" from the
URI.toURL() but the relativizing itself works OK. BTW is there any
other benefit of relativizing besides shorter names and ability to
move the project on disk while retaining of the bookmarks? (sharing is
not an issue as private.xml is not shared among users)

I'll finish cleaning of stale bookmarks and do some more testing (perf
team already expressed their interest regarding this).
Comment 36 Jesse Glick 2004-11-08 19:43:02 UTC
I think the only benefit of relativizing URLs is, as you say, in case
the project is moved on disk (but not shared). It is probably not a
priority - could be skipped if it proves difficult.

Note that relativizing to the project directory will not succeed in
the case of external source roots; there is currently no API that
would let foreign code ask a project for a "portable" name for a file
it contains (e.g. "${src.dir}/pkg/Clazz.java") that could later be
resolved back into a full file path.
Comment 37 Jan Chalupa 2004-11-09 16:02:55 UTC
Waiver approved for NB 4.0.
Comment 38 Miloslav Metelka 2005-02-22 10:43:35 UTC
I have extracted the bookmark handling into a separate editor's
submodule depending on the projects. I expect to have the changes
finished in several days.
Comment 39 Miloslav Metelka 2005-03-02 22:27:11 UTC
The bookmarks are now in a submodule editor/bookmarks which has
dependency on editor and Projects APIs. The build was preliminarily
tested by QE and several reported issues resolved.
Integrated in main trunk:

RCS file: /cvs/editor/bookmarks/.cvsignore,v
done
Checking in editor/bookmarks/.cvsignore;
/cvs/editor/bookmarks/.cvsignore,v  <--  .cvsignore
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/build.xml,v
done
Checking in editor/bookmarks/build.xml;
/cvs/editor/bookmarks/build.xml,v  <--  build.xml
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/manifest.mf,v
done
Checking in editor/bookmarks/manifest.mf;
/cvs/editor/bookmarks/manifest.mf,v  <--  manifest.mf
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file: /cvs/editor/bookmarks/nbproject/project.properties,v
done
Checking in editor/bookmarks/nbproject/project.properties;
/cvs/editor/bookmarks/nbproject/project.properties,v  <-- 
project.properties
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/nbproject/project.xml,v
done
Checking in editor/bookmarks/nbproject/project.xml;
/cvs/editor/bookmarks/nbproject/project.xml,v  <--  project.xml
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/META-INF/services/org.netbeans.lib.editor.bookmarks.spi.BookmarkManagerFactory,v
done
Checking in
editor/bookmarks/src/META-INF/services/org.netbeans.lib.editor.bookmarks.spi.BookmarkManagerFactory;
/cvs/editor/bookmarks/src/META-INF/services/org.netbeans.lib.editor.bookmarks.spi.BookmarkManagerFactory,v
 <--  org.netbeans.lib.editor.bookmarks.spi.BookmarkManagerFactory
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksApiPackageAccessor.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksApiPackageAccessor.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksApiPackageAccessor.java,v
 <--  BookmarksApiPackageAccessor.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksSpiPackageAccessor.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksSpiPackageAccessor.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksSpiPackageAccessor.java,v
 <--  BookmarksSpiPackageAccessor.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java,v
 <--  BookmarksKitInstallAction.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/Bundle.properties,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/Bundle.properties;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/Bundle.properties,v
 <--  Bundle.properties
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/GotoBookmarkAction.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/GotoBookmarkAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/GotoBookmarkAction.java,v
 <--  GotoBookmarkAction.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java,v
 <--  ToggleBookmarkAction.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/Bookmark.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/Bookmark.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/Bookmark.java,v
 <--  Bookmark.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/BookmarkList.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/BookmarkList.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/BookmarkList.java,v
 <--  BookmarkList.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkImplementation.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkImplementation.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkImplementation.java,v
 <--  BookmarkImplementation.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManager.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManager.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManager.java,v
 <--  BookmarkManager.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerFactory.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerFactory.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerFactory.java,v
 <--  BookmarkManagerFactory.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerSupport.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerSupport.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/spi/BookmarkManagerSupport.java,v
 <--  BookmarkManagerSupport.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/BookmarksXMLHandler.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/BookmarksXMLHandler.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/BookmarksXMLHandler.java,v
 <--  BookmarksXMLHandler.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/Bundle.properties,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/Bundle.properties;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/Bundle.properties,v
 <--  Bundle.properties
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/DocumentUnmodifiedListener.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/DocumentUnmodifiedListener.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/DocumentUnmodifiedListener.java,v
 <--  DocumentUnmodifiedListener.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java,v
 <--  EditorBookmarksModule.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarks.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarks.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarks.java,v
 <--  FileBookmarks.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarksMap.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarksMap.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarksMap.java,v
 <--  FileBookmarksMap.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkImplementation.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkImplementation.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkImplementation.java,v
 <--  NbBookmarkImplementation.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkManager.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkManager.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/NbBookmarkManager.java,v
 <--  NbBookmarkManager.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/PersistentBookmarks.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/PersistentBookmarks.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/PersistentBookmarks.java,v
 <--  PersistentBookmarks.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/WrapperBookmarkAction.java,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/WrapperBookmarkAction.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/WrapperBookmarkAction.java,v
 <--  WrapperBookmarkAction.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmark.xml,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmark.xml;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmark.xml,v
 <--  bookmark.xml
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmarkglyph.gif,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmarkglyph.gif;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/bookmarkglyph.gif,v
 <--  bookmarkglyph.gif
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml,v
 <--  layer.xml
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/next_bookmark.png,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/next_bookmark.png;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/next_bookmark.png,v
 <--  next_bookmark.png
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/previous_bookmark.png,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/previous_bookmark.png;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/previous_bookmark.png,v
 <--  previous_bookmark.png
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/toggle_bookmark.png,v
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/toggle_bookmark.png;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/toggle_bookmark.png,v
 <--  toggle_bookmark.png
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file: /cvs/editor/bookmarks/test/.cvsignore,v
done
Checking in editor/bookmarks/test/.cvsignore;
/cvs/editor/bookmarks/test/.cvsignore,v  <--  .cvsignore
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/test/build-qa-functional.xml,v
done
Checking in editor/bookmarks/test/build-qa-functional.xml;
/cvs/editor/bookmarks/test/build-qa-functional.xml,v  <-- 
build-qa-functional.xml
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/test/build-unit.xml,v
done
Checking in editor/bookmarks/test/build-unit.xml;
/cvs/editor/bookmarks/test/build-unit.xml,v  <--  build-unit.xml
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/test/build.xml,v
done
Checking in editor/bookmarks/test/build.xml;
/cvs/editor/bookmarks/test/build.xml,v  <--  build.xml
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/test/cfg-qa-functional.xml,v
done
Checking in editor/bookmarks/test/cfg-qa-functional.xml;
/cvs/editor/bookmarks/test/cfg-qa-functional.xml,v  <-- 
cfg-qa-functional.xml
initial revision: 1.1
done
RCS file: /cvs/editor/bookmarks/test/cfg-unit.xml,v
done
Checking in editor/bookmarks/test/cfg-unit.xml;
/cvs/editor/bookmarks/test/cfg-unit.xml,v  <--  cfg-unit.xml
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/build.xml,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/build.xml;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/build.xml,v
 <--  build.xml
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/.cvsignore,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/.cvsignore;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/.cvsignore,v
 <--  .cvsignore
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/build-impl.xml,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/build-impl.xml;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/build-impl.xml,v
 <--  build-impl.xml
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/genfiles.properties,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/genfiles.properties;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/genfiles.properties,v
 <--  genfiles.properties
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.properties,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.properties;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.properties,v
 <--  project.properties
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.xml,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.xml;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/nbproject/project.xml,v
 <--  project.xml
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/src/bookmarks/BookmarksPersistenceTest/testPersistence.java,v
done
Checking in
editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/src/bookmarks/BookmarksPersistenceTest/testPersistence.java;
/cvs/editor/bookmarks/test/qa-functional/data/projects/editor_bookmarks_test/src/bookmarks/BookmarksPersistenceTest/testPersistence.java,v
 <--  testPersistence.java
initial revision: 1.1
done
Processing log script arguments...
More commits to come...
RCS file:
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksPersistenceTest.java,v
done
Checking in
editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksPersistenceTest.java;
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksPersistenceTest.java,v
 <--  BookmarksPersistenceTest.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksTestSuite.java,v
done
Checking in
editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksTestSuite.java;
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/BookmarksTestSuite.java,v
 <--  BookmarksTestSuite.java
initial revision: 1.1
done
RCS file:
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/EditorBookmarksTestCase.java,v
done
Checking in
editor/bookmarks/test/qa-functional/src/bookmarks/EditorBookmarksTestCase.java;
/cvs/editor/bookmarks/test/qa-functional/src/bookmarks/EditorBookmarksTestCase.java,v
 <--  EditorBookmarksTestCase.javainitial revision: 1.1
done
Processing log script arguments...
More commits to come...
Checking in editor/libsrc/org/netbeans/editor/ActionFactory.java;
/cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v  <-- 
ActionFactory.java
new revision: 1.63; previous revision: 1.62
done
Checking in editor/libsrc/org/netbeans/editor/BaseAction.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseAction.java,v  <-- 
BaseAction.java
new revision: 1.37; previous revision: 1.36
done
Checking in editor/libsrc/org/netbeans/editor/BaseDocument.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseDocument.java,v  <-- 
BaseDocument.java
new revision: 1.112; previous revision: 1.111
done
Checking in editor/libsrc/org/netbeans/editor/BaseKit.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseKit.java,v  <--  BaseKit.java
new revision: 1.129; previous revision: 1.128
done
Checking in
editor/libsrc/org/netbeans/editor/BaseSettingsInitializer.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseSettingsInitializer.java,v
 <--  BaseSettingsInitializer.java
new revision: 1.25; previous revision: 1.24
done
Removing editor/libsrc/org/netbeans/editor/Bookmarks.java;
/cvs/editor/libsrc/org/netbeans/editor/Bookmarks.java,v  <-- 
Bookmarks.java
new revision: delete; previous revision: 1.3
done
Checking in editor/libsrc/org/netbeans/editor/Bundle.properties;
/cvs/editor/libsrc/org/netbeans/editor/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.58; previous revision: 1.57
done
Checking in editor/libsrc/org/netbeans/editor/DrawLayerFactory.java;
/cvs/editor/libsrc/org/netbeans/editor/DrawLayerFactory.java,v  <-- 
DrawLayerFactory.java
new revision: 1.45; previous revision: 1.44
done
Checking in editor/libsrc/org/netbeans/editor/EditorUI.java;
/cvs/editor/libsrc/org/netbeans/editor/EditorUI.java,v  <--  EditorUI.java
new revision: 1.70; previous revision: 1.69
done
Checking in editor/libsrc/org/netbeans/editor/SettingsDefaults.java;
/cvs/editor/libsrc/org/netbeans/editor/SettingsDefaults.java,v  <-- 
SettingsDefaults.java
new revision: 1.49; previous revision: 1.48
done
Checking in editor/libsrc/org/netbeans/editor/SettingsNames.java;
/cvs/editor/libsrc/org/netbeans/editor/SettingsNames.java,v  <-- 
SettingsNames.java
new revision: 1.19; previous revision: 1.18
done
Processing log script arguments...
More commits to come...
Checking in editor/src/org/netbeans/modules/editor/Bundle.properties;
/cvs/editor/src/org/netbeans/modules/editor/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.46; previous revision: 1.45
done
Checking in editor/src/org/netbeans/modules/editor/NbEditorKit.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorKit.java,v  <-- 
NbEditorKit.java
new revision: 1.81; previous revision: 1.80
done
Checking in editor/src/org/netbeans/modules/editor/NbEditorToolBar.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorToolBar.java,v 
<--  NbEditorToolBar.java
new revision: 1.11; previous revision: 1.10
done
Checking in editor/src/org/netbeans/modules/editor/NbEditorUtilities.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorUtilities.java,v 
<--  NbEditorUtilities.java
new revision: 1.17; previous revision: 1.16
done
Processing log script arguments...
More commits to come...
Removing
editor/src/org/netbeans/modules/editor/resources/bookmarkglyph.gif;
/cvs/editor/src/org/netbeans/modules/editor/resources/bookmarkglyph.gif,v
 <--  bookmarkglyph.gif
new revision: delete; previous revision: 1.3
done
Checking in editor/src/org/netbeans/modules/editor/resources/layer.xml;
/cvs/editor/src/org/netbeans/modules/editor/resources/layer.xml,v  <--
 layer.xml
new revision: 1.68; previous revision: 1.67
done
Removing
editor/src/org/netbeans/modules/editor/resources/next_bookmark.png;
/cvs/editor/src/org/netbeans/modules/editor/resources/next_bookmark.png,v
 <--  next_bookmark.png
new revision: delete; previous revision: 1.1
done
Removing
editor/src/org/netbeans/modules/editor/resources/previous_bookmark.png;
/cvs/editor/src/org/netbeans/modules/editor/resources/previous_bookmark.png,v
 <--  previous_bookmark.png
new revision: delete; previous revision: 1.1
done
Removing
editor/src/org/netbeans/modules/editor/resources/toggle_bookmark.png;
/cvs/editor/src/org/netbeans/modules/editor/resources/toggle_bookmark.png,v
 <--  toggle_bookmark.png
new revision: delete; previous revision: 1.1
done
Processing log script arguments...
More commits to come...
Removing
editor/src/org/netbeans/modules/editor/resources/AnnotationTypes/bookmark.xml;
/cvs/editor/src/org/netbeans/modules/editor/resources/AnnotationTypes/bookmark.xml,v
 <--  bookmark.xml
new revision: delete; previous revision: 1.4
done
Processing log script arguments...
More commits to come...
Checking in
editor/src/org/netbeans/modules/editor/resources/XMLs/DefaultGlobalKeyBindings.xml;
/cvs/editor/src/org/netbeans/modules/editor/resources/XMLs/DefaultGlobalKeyBindings.xml,v
 <--  DefaultGlobalKeyBindings.xml
new revision: 1.19; previous revision: 1.18
done
Processing log script arguments...
More commits to come...
Checking in ide/golden/deps.txt;
/cvs/ide/golden/deps.txt,v  <--  deps.txt
new revision: 1.42; previous revision: 1.41
done
Checking in ide/golden/files-layout.txt;
/cvs/ide/golden/files-layout.txt,v  <--  files-layout.txt
new revision: 1.29; previous revision: 1.28
done
Checking in ide/golden/modules.txt;
/cvs/ide/golden/modules.txt,v  <--  modules.txt
new revision: 1.12; previous revision: 1.11
done
Processing log script arguments...
More commits to come...
Checking in nbbuild/build.properties;
/cvs/nbbuild/build.properties,v  <--  build.properties
new revision: 1.240; previous revision: 1.239
done
Checking in nbbuild/build.xml;
/cvs/nbbuild/build.xml,v  <--  build.xml
new revision: 1.645; previous revision: 1.644
done
Checking in nbbuild/cluster.properties;
/cvs/nbbuild/cluster.properties,v  <--  cluster.properties
new revision: 1.77; previous revision: 1.76
done
Processing log script arguments...
More commits to come...
Checking in nbbuild/templates/modules.xml;
/cvs/nbbuild/templates/modules.xml,v  <--  modules.xml
new revision: 1.86; previous revision: 1.85
done
Comment 40 Jan Lahoda 2005-03-07 15:57:41 UTC
Verified, build 200503061900.
Comment 41 Jesse Glick 2005-06-16 18:17:32 UTC
*** Issue 59963 has been marked as a duplicate of this issue. ***