This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 132720 [details] Result of test for scrollable resultsets Attached you find a patch series, that a) cleans up the table models/handling in the db.dataview module b) make LOB fields accessible when the view is not editable (ex. in joins) c) switch to use scrollable resultsets if available (simlifies the SQL handling) d) fix bug in primary key handling (a partial composite key was acceptet as a valid identifier for a table) e) implements display of multiple resultsets (bug 73341) f) simplifies the JXTableRowHeadder (bug 205307) I'll also attach a protocol of my quick check of scrollable resultset support. I had only one fail, so I'm pretty confident, that the JDBC drivers matured enougth to use this feature.
Created attachment 132721 [details] Make SQLStatementExecutorTest work reliable (AXION held internal views open, that prevented simpletable from drop)
Created attachment 132722 [details] 02 Preclean Celleditors
Created attachment 132723 [details] 03 Cleanup TableModels
Created attachment 132724 [details] 04 NumberFieldEditor should return Numbers,not strings
Created attachment 132725 [details] 05 Fix JXTableRowHeader to react to changes in the table model
Created attachment 132726 [details] 06 Enable display of LOB values in read-only tables
Created attachment 132727 [details] 07 Use scrollable resultset for efficient queries (replaces SQL mangeling)
Created attachment 132728 [details] 08 Move paging handling (display part) completly into DataViewPageContext
Created attachment 132729 [details] 09 Fix display of "page" and total row count for the "unknown row count case"
Created attachment 132730 [details] 10 Fix spelling of DataViewDBTable#getTable and DataViewDBTable#getTableCount
Created attachment 132731 [details] 11 Make SQLStatementGenerator independent of DataVIew
Created attachment 132732 [details] 12 Move tblMetaData into DavaViewPageContext
Created attachment 132733 [details] 13 Move editable handling completly into the DataViewTableUIModel
Created attachment 132734 [details] 14 Correct handling of composite primary keys
Created attachment 132735 [details] 15 Handle multiple resultsets from sql
Wow, great job! Thank you very much, Matthias. I've applied the patches locally and I'm testing them now. If everything goes well, I'll push the changes to repository in a few hours.
Applied as core-main #8d338de53196, #ddb67b8a29de, #345ea2a50dd6, #ef61f0ef8dce, #eea56a79fe8c, #2544049e1c63, #877efcefc70d, #703dcdbf7e71, #db24ed0f1dd8, #c624d0b53da5, #7116387436bf, #36bcd5a21e11, #dbc6ebe16347, #7357da8c17bf, #5c6fcd257573
Created attachment 132790 [details] Exception in DataViewTableUI#getCellRenderer Exception encountered while setting page size or moving to next/previous page. I've discovered two small issues: DataViewTableUI#getCellRenderer should not probably throw any exception when the cell is not in the model. The "Previous page" button was enabled if the first page was shown. Fixed in http://hg.netbeans.org/core-main/rev/7fbd44e93df0 Please check it. Thank you for all the patches, Matthias!
I think I know the reason for the exception. There are changes done to the DataViewTableUIModel off the EDT - this just cries for problems. I'll look into it in the next days, but I'm not sure when to get to it. This needs some serious reworks in SQLExcecutionHelper, as calls are wildly scattered. Most probably wrapping the finally part in SQLExcecutionHelper#loadDataFrom into Mutex.Event#writeAccess would already go a long way (the most brutal update is moved into the EDT by this). Thanks for the very fast reaction Jaroslav!
Integrated into 'main-golden', will be available in build *201303192300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/8d338de53196 User: Jaroslav Havlin <jhavlin@netbeans.org> Log: #227588: Make SQLStatementExecutorTest work reliable (AXION held internal views open, that prevented simpletable from drop) Patch from Matthias42
Created attachment 132995 [details] 16 Improve handling of EDT in dataview The attached patch should improve the situation. The critical sections are guarded by Mutex.Event#writeAccess - forcing updates into the EDT should eliminate problems while rendering (your exception report). Please give it a spin. I'll attach another patch - the row header size changed while edditing the content - the attached patch fixes this by forcing a reasonable size (fitting five digits).
Created attachment 132996 [details] 17 Fix changing width row header
(In reply to comment #21) > Created attachment 132995 [details] > 16 Improve handling of EDT in dataview Thank you very much for another huge patch! Integrated as http://hg.netbeans.org/core-main/rev/9711f16a0085 > I'll attach another patch - the row header size changed while edditing the > content - the attached patch fixes this by forcing a reasonable size (fitting > five digits). Integrated as http://hg.netbeans.org/core-main/rev/4e4efc1ec6af Thanks again.