This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 218774 - Accessing file system in EDT: selecting library files in go to file dialog
Summary: Accessing file system in EDT: selecting library files in go to file dialog
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Model (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Andrew Krasny
URL:
Keywords: PERFORMANCE
Depends on: 223668
Blocks: 218138
  Show dependency tree
 
Reported: 2012-09-21 13:19 UTC by Egor Ushakov
Modified: 2012-12-14 02:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
stacktrace (7.92 KB, text/plain)
2012-09-21 13:20 UTC, Egor Ushakov 		Details
Proposed fix (5.54 KB, patch)
2012-12-11 09:48 UTC, Andrew Krasny 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egor Ushakov 2012-09-21 13:19:41 UTC 
when there are some library files in the results in "go to file" dialog and user clicks on them NB to get file name displayed below goes to file system in EDT, see attached stacktrace
Comment 1 Egor Ushakov 2012-09-21 13:20:02 UTC 
Created attachment 124717 [details]
stacktrace
Comment 2 Vladimir Voskresensky 2012-12-11 06:22:52 UTC 
Andrew, please, have a look
Comment 3 Andrew Krasny 2012-12-11 09:11:50 UTC 
I would propose to made changes in the infrastructure rather than trying to overcome the problem in the cnd's code... 
IMO a good solution would be to extend FileDescriptor with a method like 
String getFilePath() and use it for selection/tooltips.
Comment 4 Andrew Krasny 2012-12-11 09:48:03 UTC 
Created attachment 129195 [details]
Proposed fix
Comment 5 Vladimir Voskresensky 2012-12-12 15:39:29 UTC 
not a problem after caching FO in FileBuffer
http://hg.netbeans.org/cnd-main/rev/bcec3659efdd

*** This bug has been marked as a duplicate of bug 218790 ***
Comment 6 Vladimir Voskresensky 2012-12-12 16:28:41 UTC 
Andrew, after issue #223668 was fixed. May it's still better to provide FO independent file name on our side?
Comment 7 Andrew Krasny 2012-12-12 20:49:06 UTC 
What I cannot understand is why the status of the bug (that I'm working on) is changed by others (vv) while nothing was done for it's resolution yet. 

Yes, it requires a fix (the proposed one) on our side. Yes, I will do this - I was waiting for a fix in the API.
Comment 8 Andrew Krasny 2012-12-13 09:18:20 UTC 
http://hg.netbeans.org/cnd-main/rev/3c6bd7c5e1c8
Comment 9 Quality Engineering 2012-12-14 02:44:43 UTC 
Integrated into 'main-golden', will be available in build *201212140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/0546c30ff36e
User: Andrew Krasny <akrasny@netbeans.org>
Log: Bug #218774 - Accessing file system in EDT: selecting library files in go to file dialog
Use CsmModelAccessor.getModel().enqueue() instead of own RP for opening a file.