This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 121552 [details] protocol of installer build process After reading that 7.2 RC1 is available, i installed it immediately to play around a bit. I opened my project and tried to run it without a problem. But when i tried to package it, an error occurred: C:\Program Files\NetBeans 7.2 RC1\harness\nbi\stub\template.xml:41: The following error occurred while executing this line: C:\Users\David\Documents\NetBeansProjects\Ganesha\build\installer\build.xml:116: The following error occurred while executing this line: C:\Users\David\Documents\NetBeansProjects\Ganesha\build\installer\nbi_all\.common\product.xml:485: src 'C:\Users\David\Documents\NetBeansProjects\Ganesha\dist\${branding.token}.zip' doesn't exist. It seems that at some point the variable "${branding.token}" is not evaluated correctly because when i look in the created directories in "build\installer" i find some files named like "${branding.token}.gif". Also, under "build\installer\ext\components\products" there is a subdirectory "helloworld" that for sure doesn't belong to my project. I'll attach the protocol to this message.
I am experiencing the same with NetBeans IDE 7.2 RC1 (Build 201206141830). Steps to reproduce: 1. Create a new Ant-based NetBeans Platform Application. 2. Choose Package As > Installers from the project's context menu. This still happens if I add a new module to the application. I checked that the branding name is specified in the application project's properties (Application category) and also that at least one installer is checked in the Installer category. And I even specified an application icon in the branding options to check whether that would make a difference. But the problem persists.
This is a regression, since this feature works as expected in NetBeans 7.1.1 (build 201203012225). I created a project with NetBeans 7.1.1 and one with NetBeans 7.2 and compared them. In the 7.1.1 project, branding.token is specified in project.properties, while it is in platform.properties for 7.2. That is the only significant difference that I found between the two folders. I don't know whether this change was intentional, but IMHO logically it makes more sense to have that in project.properties. The interesting thing is that I could build installers for the project created with 7.1.1, using the harness and platform of 7.2 in the IDE 7.2. But just moving the branding.token for the new project from the one file to the other did not help... So the (ugly) workaround for this issue is to create the suite with 7.1.1 instead of 7.2. :)
mienamoo, you're very close to right solution :) It's correct the branding.token is moved to project.properties. The problem is that the branding.token isn't replaced while creating or changing project properties... So simple workaround: in <project folder>/nbproject/project.properties change property branding.token to your application name. The correct app name is in platform.properties - branding.token
Awesome thanks! That does indeed work! :D
Caused by issue 197066. Milos, can you look at it? It should be simple fix in setting project properties.
Candidate for 7.2 FCS imho: The bug will need to be fixed in org.netbeans.modules.apisupport.installer.actions.BuildInstallersAction which is either part of installer or Ant apisupport.
Opps, I wanted to set different priority.
Created attachment 121820 [details] Read branding.token property from platform.properties, if it is there Jirko, Miloši, please review.
The patch looks ok, I haven't verified that it indeed fixes the problem.
Can you please integrate patch to trunk? I'll verify ASAP..then we can evaluate putting it to 7.2.. Thanks in advance. (In reply to comment #6) > Candidate for 7.2 FCS imho: > > The bug will need to be fixed in > org.netbeans.modules.apisupport.installer.actions.BuildInstallersAction > which is either part of installer or Ant apisupport.
ergonomics#ffe6a21bdd05
The patch looks good for me too. Thanks (In reply to comment #10) > Can you please integrate patch to trunk? I'll verify ASAP. Also was transplanted to core-main for your easy verification - http://hg.netbeans.org/core-main/rev/9b1112a899da >then we can evaluate putting it to 7.2.. > Thanks in advance. > > (In reply to comment #6) > > Candidate for 7.2 FCS imho: > > > > The bug will need to be fixed in > > org.netbeans.modules.apisupport.installer.actions.BuildInstallersAction > > which is either part of installer or Ant apisupport.
Unfortunatelly fix does not help, build of installers still fail. Since it's late for another attempt, adding RELNOTE keyword and 72patch_candidate sw.
ergonomics#6a822de260f9
Improved fix integrated into release72 branch: d224ea722320
Integrated into 'releases', will be available in build *201207092359* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/d224ea722320 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #214983: Backport of so-so fix into release72. Works at least with newly created project. Who knows what it does after some extensive re-configurations...
Fix (hack) seems to work in 7.2, verified. Product Version: NetBeans IDE 7.2 (Build 201207092359) Java: 1.7.0_06-ea; Java HotSpot(TM) 64-Bit Server VM 23.2-b08 System: Mac OS X version 10.7.4 running on x86_64; US-ASCII; en_US (nb) User directory: /Users/tomas/Library/Application Support/NetBeans/7.2 Cache directory: /Users/tomas/Library/Caches/NetBeans/7.2
Integrated into 'main-golden', will be available in build *201207110002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/9b1112a899da User: Jaroslav Tulach <jtulach@netbeans.org> Log: #214983: Read branding.token from platform.properties if it is there (transplanted from ffe6a21bdd05100e07d52d3a64111b5e38c32239)