This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 121402 [details] screenshot To reproduce: 1) Download PHP build (sh file) and install it. At this moment if you invoke code completion (at the place of "|") in some css file (or in <style> tag): div{ color: | } you get a list of colors 2) Upgrade (extend) IDE by installing all modules (JavaEE, JavaSE...) - only from NetBeans Distribution 3) After all is installed, restart IDE and repeat code completion from step 1 => CC is corrupted (see screenshot) The same happens with update from Java build to All. Product Version: NetBeans IDE 7.2 RC1 (Build 201206252201) Java: 1.7.0_05; Java HotSpot(TM) Client VM 23.1-b03 System: Linux version 3.0.0-21-generic-pae running on i386; UTF-8; en_US (nb)
Note that at least completion list for "background" property is also broken
I guess that completion for every property which could have some color value is broken. Some more examples: border, box-shadow, outline, outline-color
Vlado, is this really P1? Looks like P2 or P3 to me.
Maybe but after the upgrade I didn't find a way to make the cc working as before again. If the color values are the only one affected, it could have a lower priority.
It is broken due to installation of java fx css editor extension which is completely screwed up and I never even thought it was ment to be seriously put into a build.
javafx2.editor should not install its erroneous CssEditorModule extension. From what I remember when Anton was making it it was never properly completed, it was just a prototype, at least from my point of view. If javafx needs really this it requires non trivial fixes on the css editor side to make it work properly.
This is a stopper for NB 7.2 RC1, please evaluate and resolve by 10pm CEST Today! Thanks in advance.
Upon an agreement with Petr Somol, I've fixed the most flagrant issues in the javafx css editor module properties definition file. I've also added some kind of support in the css.editor module allowing the editor features to access proper set of css properties based on the file project. If the project is java-fx project, then the java fx extension properties are not taken into account. http://hg.netbeans.org/web-main/rev/b95f9fa4d86e Petr needs to implement the CssModuleSupport's private static boolean isJavaFxProject(Project project) { 3.46 + //Petr Somol, please add an proper implementation here! 3.47 + return false; 3.48 + } method to make it really work.
css.editor module tests passes, the fix should not cause any regressions. I haven't tested the java fx css editing at all, so this is fully up to Petr and/or Vlada.
btw the changes to the javafx2.properties are not really necessary. So if you want to minimize the risk (and keep the absolutely screwed state of the java fx's css editor) just integrate the changes to the css.editor module along with implementing the mentioned isJavaFxProject(...) method. There's some risk of integrating the javafx2.properties file changes since I just edited the file w/o really testing it or running any unit tests (if there are any at the javafx side). I also expect Petr will run the necessary actions regarding the 72 integration process (review, verification, testing, merge ...).
(In reply to comment #9) > css.editor module tests passes, the fix should not cause any regressions. I > haven't tested the java fx css editing at all, so this is fully up to Petr > and/or Vlada. Thanks Marku, I'll try to reproduce the upgrade scenario and test css as well. As for the JavaFX, I don't know it at all, maybe Stepan can help?
I've just noticed I'd forgotten to negate one boolean, so Petre please apply following diff along with implementing the isJavaFxproject() method. Thanks diff -r f5f858033c0d css.editor/src/org/netbeans/modules/css/editor/module/CssModuleSupport.java --- a/css.editor/src/org/netbeans/modules/css/editor/module/CssModuleSupport.java Wed Jun 27 15:38:59 2012 +0200 +++ b/css.editor/src/org/netbeans/modules/css/editor/module/CssModuleSupport.java Wed Jun 27 16:01:52 2012 +0200 @@ -280,7 +280,7 @@ } public static Collection<Property> getProperties(FileObject file) { - return getProperties(isJavaFxCssFile(file)); + return getProperties(!isJavaFxCssFile(file)); }
rest of fix pushed in jetmain: http://hg.netbeans.org/jet-main/rev/77acb6ad5cf3
verified in trunk I build from web-main with Petr's changes from jetmain, add a RC catalog link as a new source to Tools|Plugins and upgrade from build (cluster basic) to All. CSS and JavaFX CSS seems fine. Product Version: NetBeans IDE Dev (Build 20120627-50e56ee1d85b) Java: 1.7.0_05; Java HotSpot(TM) Client VM 23.1-b03 System: Linux version 3.0.0-21-generic-pae running on i386; UTF-8; en_US (nb)
transplanted to releases release72 branch as changesets 033bd6edb71e, 87746ae04f6c, 6de9714f7a75
Integrated into 'main-golden', will be available in build *201206280002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/b95f9fa4d86e User: Marek Fukala <mfukala@netbeans.org> Log: #214819 - not yet complete fix - Completion list is corrupted after IDE upgrade
Integrated into 'releases', will be available in build *201206272359* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/033bd6edb71e User: Marek Fukala <mfukala@netbeans.org> Log: #214819 - not yet complete fix - Completion list is corrupted after IDE upgrade
verified in 7.2 Product Version: NetBeans IDE 7.2 RC1 (Build 201206272359) Java: 1.7.0_05; Java HotSpot(TM) Client VM 23.1-b03 System: Linux version 3.0.0-21-generic-pae running on i386; UTF-8; en_US (nb)