This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 211785 - License Agreement appears again and again
Summary: License Agreement appears again and again
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 7.2
Hardware: PC Windows 7
: P1 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: REGRESSION
: 211233 211812 (view as bug list)
Depends on:
Blocks: 211233
  Show dependency tree
 
Reported: 2012-04-26 13:18 UTC by Jiri Skrivanek
Modified: 2012-10-10 07:33 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
My current version of platform/core/core.jar (829.30 KB, application/octet-stream)
2012-04-27 15:26 UTC, Jaroslav Tulach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2012-04-26 13:18:13 UTC
License Agreement appears again and again during startup in spite already accepted. Started to happen in the latest trunk build.

Product Version: NetBeans IDE Dev (Build 201204260400)
Java: 1.7.0_04; Java HotSpot(TM) 64-Bit Server VM 23.0-b21
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
User directory: D:\Development\builds\nbUserdir-20120426151231
Cache directory: D:\Development\builds\nbUserdir-20120426151231\var\cache
Comment 1 Jiri Rechtacek 2012-04-26 13:59:45 UTC
I guess it's caused by http://hg.netbeans.org/main-silver/rev/1a15d7e31cd9 
If I'm wrong, assign to other suspected component if any. Thanks
Comment 2 Jiri Rechtacek 2012-04-26 14:01:40 UTC
Btw. I saw it yesterday on my linux.
Comment 3 Jesse Glick 2012-04-26 19:44:23 UTC
The old code was possibly wrong; the new code is definitely wrong, since this file is not part of any NBM fileset. Need to use:

File f = new File(Places.getUserDirectory(), "var/license_accepted");
Comment 4 Jiri Rechtacek 2012-04-27 05:50:02 UTC
*** Bug 211812 has been marked as a duplicate of this bug. ***
Comment 5 Jaroslav Tulach 2012-04-27 06:33:20 UTC
OK, I don't believe the old code is wrong. It is there for five years. Rather, the way IFL was changed to work (e.g. require cnb or complain) is incompatible. I will rollback the change.
Comment 6 Jaroslav Tulach 2012-04-27 06:47:04 UTC
ergonomics#cacd5734cffd
Comment 7 Antonin Nebuzelsky 2012-04-27 12:11:23 UTC
Stopper for Beta.

Jardo, backport to release72_beta. Thanks.
Comment 8 Jaroslav Tulach 2012-04-27 12:27:17 UTC
Can anyone verify, so I can integrate to release72_beta?
Comment 9 Jaroslav Tulach 2012-04-27 14:44:36 UTC
Tomáš and Jirka reported that this problem is not yet fixed.
Comment 10 Jaroslav Tulach 2012-04-27 15:07:13 UTC
*** Bug 211233 has been marked as a duplicate of this bug. ***
Comment 11 Jaroslav Tulach 2012-04-27 15:23:41 UTC
One more try: ergonomics#5df317716eb2

Use
$ hg pull -r 5df317716eb2 http://hg.netbeans.org/ergonomics 
$ hg merge
to get my changes into your repository (releases or any other).
Comment 12 Jaroslav Tulach 2012-04-27 15:26:54 UTC
Created attachment 118884 [details]
My current version of platform/core/core.jar
Comment 13 mrpc 2012-04-27 15:36:33 UTC
Happens to me too on mac os x lion:
Product Version: NetBeans IDE Dev (Build 201204260400)
Java: 1.6.0_31; Java HotSpot(TM) 64-Bit Server VM 20.6-b01-415
System: Mac OS X version 10.7.3 running on x86_64; MacGreek; el_GR (nb)
Comment 14 Jesse Glick 2012-04-27 16:42:00 UTC
(In reply to comment #5)
> I don't believe the old code is wrong. It is there for five years.

Well then it was wrong for five years and no one noticed because IFLI was sloppy. IFL is only for loading files managed by autoupdate, which this is not.

Is there some problem with using Places? Do we expect to find var/license_accepted anywhere besides the user directory?
Comment 15 Jesse Glick 2012-04-27 17:11:58 UTC
I see: org.netbeans.installer.utils.applications.NetBeansUtils.createLicenseAcceptedMarker does create it in the nb cluster, I guess because it cannot predict the userdir at this point (though other methods in this class claim to do so), or wishes to indicate acceptance given any userdir based on this installation (?); and it neglects the modify any nb/update_tracking/*.xml to reflect the existence of this file, meaning it is invisible to IFL. So 5df317716eb2 should be fine - checks in both ${netbeans.user} (runtime license acceptance) and the .../nb element of ${netbeans.dirs} (install-time acceptance).
Comment 16 Tomas Danek 2012-05-01 08:27:06 UTC
As note in emails offline, this fix seems to work.

(In reply to comment #12)
> Created attachment 118884 [details]
> My current version of platform/core/core.jar
Comment 17 Jaroslav Tulach 2012-05-02 08:47:07 UTC
changeset:  3a5fd6b20cb3
branch:      release72_beta
tag:         tip
parent:      b0ec3ddd67fe
parent:      5df317716eb2
user:        Jaroslav Tulach <jtulach@netbeans.org>
date:        Wed May 02 10:46:20 2012 +0200
summary:     Merge of #211785 to 7.2 beta branch
Comment 18 Quality Engineering 2012-05-02 10:04:14 UTC
Integrated into 'main-golden', will be available in build *201205020400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/cacd5734cffd
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #211785: Backed out fix for bug #211233
Comment 19 Quality Engineering 2012-10-10 07:33:50 UTC
Integrated into 'releases', will be available in build *201210100002* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/3a5fd6b20cb3
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: Merge of #211785 to 7.2 beta branch