This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 210973 - Different behaviour of Actions.ButtonBridge and Actions.MenuBridge causes branding problems
Summary: Different behaviour of Actions.ButtonBridge and Actions.MenuBridge causes bra...
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Actions (show other bugs)
Version: 7.0.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-10 18:51 UTC by NeilCSmith
Modified: 2012-05-21 15:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description NeilCSmith 2012-04-10 18:51:12 UTC
There seems to be a weird bug in Actions whereby ButtonBridge prioritizes the iconBase attribute and MenuBridge prioritizes the SMALL_ICON attribute.  I noticed this while trying to brand icons from ProjectUI actions.  These, probably incorrectly, set a non-localized icon to SMALL_ICON as well as setting iconBase.  This makes it impossible to brand menu icons, though toolbar icons are fine.

Full details and a workaround using ButtonActionConnector here - http://praxisintermedia.wordpress.com/2012/04/10/branding-project-action-icons/
Comment 1 Jaroslav Tulach 2012-05-18 15:09:06 UTC
ergonomics#d95cdf08bb4f
Comment 2 Quality Engineering 2012-05-19 09:58:00 UTC
Integrated into 'main-golden', will be available in build *201205190400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d95cdf08bb4f
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #210973: Preferring "iconBase" if it is specified
Comment 3 Jesse Glick 2012-05-21 14:30:47 UTC
(In reply to comment #0)
> I noticed this while trying to brand icons from ProjectUI actions.  These,
> probably incorrectly, set a non-localized icon to SMALL_ICON as well as setting
> iconBase.

Feel free to file a bug report in projects/projectui with details (or even a patch) - it may be accidental to set both.
Comment 4 NeilCSmith 2012-05-21 15:42:03 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > I noticed this while trying to brand icons from ProjectUI actions.  These,
> > probably incorrectly, set a non-localized icon to SMALL_ICON as well as setting
> > iconBase.
> 
> Feel free to file a bug report in projects/projectui with details (or even a
> patch) - it may be accidental to set both.

OK, done - bug 212796.  

Thanks, Neil