This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 208240 - API Review: ReplaceConstructorWithFactoryRefactoring, ReplaceConstructorWithBuilderRefactoring and InvertBooleanRefactoring
Summary: API Review: ReplaceConstructorWithFactoryRefactoring, ReplaceConstructorWithB...
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Jan Becicka
URL:
Keywords: API_REVIEW, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2012-02-10 11:07 UTC by Jan Becicka
Modified: 2012-04-02 15:57 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
InvertBoolean (3.05 KB, application/octet-stream)
2012-02-10 11:11 UTC, Jan Becicka 		Details
ReplaceConstructorWithBuilder (5.83 KB, application/octet-stream)
2012-02-10 11:11 UTC, Jan Becicka 		Details
ReplaceConstructorWithFactory (3.01 KB, application/octet-stream)
2012-02-10 11:12 UTC, Jan Becicka 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2012-02-10 11:07:41 UTC 
Please review API for 3 new refactorings.
Comment 1 Jan Becicka 2012-02-10 11:09:34 UTC 
        <change id="ReplaceConstructorWithBuilder-ReplaceConstructorWithFactory-InvertBoolean">
            <api name="refactoring"/>
            <summary>New refactorings on board: ReplaceConstructorWithFactory, ReplaceConstructorWithBuilder and InvertBoolean</summary>
            <version major="1" minor="34"/>
            <date day="10" month="2" year="2012"/>
            <author login="jbecicka"/>
            <compatibility addition="yes"/>
            <description>
                <p>
                    New refactorings on board: ReplaceConstructorWithFactoryRefactoring, ReplaceConstructorWithBuilderRefactoring and InvertBooleanRefactoring.
                </p>    
            </description>
            <class package="org.netbeans.modules.refactoring.java.api" name="ReplaceConstructorWithFactoryRefactoring"/>
            <class package="org.netbeans.modules.refactoring.java.api" name="ReplaceConstructorWithBuilderRefactoring"/>
            <class package="org.netbeans.modules.refactoring.java.api" name="InvertBoolean"/>
            <issue number="208240"/>
        </change>
Comment 2 Jan Becicka 2012-02-10 11:11:15 UTC 
Created attachment 115571 [details]
InvertBoolean
Comment 3 Jan Becicka 2012-02-10 11:11:53 UTC 
Created attachment 115573 [details]
ReplaceConstructorWithBuilder
Comment 4 Jan Becicka 2012-02-10 11:12:23 UTC 
Created attachment 115574 [details]
ReplaceConstructorWithFactory
Comment 5 Jan Becicka 2012-02-10 11:14:05 UTC 
Please review attached API classes and please ignore package names.
Comment 6 Ralph Ruijs 2012-02-10 11:41:14 UTC 
[R01] ReplaceConstructorWithFactoryRefactoring.getFactoryName can return null, despite the @NonNull annotation. Please initialize or change the annotation. (same for other properties).

[R02] When doing an invert boolean, I do not think you always want to change the name. Of course you can give the old name to the InvertBooleanRefactoring, but it would be easier to be able to set the new name to null.
Comment 7 Jan Becicka 2012-03-29 12:49:33 UTC 
http://hg.netbeans.org/jet-main/rev/49de580e6a2a
Comment 8 Quality Engineering 2012-04-02 15:57:46 UTC 
Integrated into 'main-golden', will be available in build *201204021038* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/49de580e6a2a
User: Jan Becicka <jbecicka@netbeans.org>
Log: Issue #208240 - API Review: ReplaceConstructorWithFactoryRefactoring, ReplaceConstructorWithBuilderRefactoring and InvertBooleanRefactoring
Issue #208240 - API Review: ReplaceConstructorWithFactoryRefactoring, ReplaceConstructorWithBuilderRefactoring and InvertBooleanRefactoring