This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The problem: I have included some folders to the project include path. If I search a specific string in my project, the files under the project include path are not considered. In other words, even if the string I am searching for occurs in any of the files under my project include path, it is not shown in Search Results. Expected behaviour: All occurrences displayed.
just a notes: - find usages works also for include path - find/search on the project subnode representing include path works as expeceted
Created attachment 101748 [details] attached patch
Tomasi, could you please review the attached fix and what's more important I would like to hear your opinion whether this should be implemented unconditionally (meaning w/o UI checkbox in options "Search also in include path")? Thanks
(In reply to comment #3) > Tomasi, could you please review the attached fix Patch seems to be OK. > what's more important I > would like to hear your opinion whether this should be implemented > unconditionally (meaning w/o UI checkbox in options "Search also in include > path")? Well, we cannot have a look at Java; so what about Ruby? In any case, I would expect that some UI for it should be present because Include Path can contain _huge_ number of files (can be _very_ slow then); also, if one wants to search in a project, then one perhaps expects that only project will be searched (moreover if one can use search on Include Path node that is present in every project). So, I would prefer to have a checkbox for it (maybe just in Tools > Options >PHP?)
Yes, user should be aware what he can expect and what will happen - in this case that it may take more time. But maybe we don't need additional UI checkbox because logical view may is enough for user to understand what is going to happen. So, search on(see logical view below): - "Project" node will search in sources and include path - "Sources" node will search in sources only - "Include Path" node will search in include path only Logical View looks like this: . |-- Project | `-- Sources | `-- Include Path So, I suggest to put in in according to patch (1:1) without additional checkbox because seems to me to be clear and not confusing from user point of view
How to search only in project directory, without the include path? There would be no way to do it. Please notice that the project directory can contain a lot more files than just Source Files.
. |-- Project | `-- Sources | `-- Include Path OK, Include Path node is under project, so one can expect that it will look also in include path. On the other hand being able to switch it off might be welcomed. So, now the last decision is default value: *as default* find in include path or not?
Now I see, for searching only in project directory, one can probably use Files view. So, I guess the patch could stay as it is.
Still interested - how does it work in Ruby?
Integrated into 'main-golden', will be available in build *201009020000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/8fcd37001b8b User: Radek Matous <rmatous@netbeans.org> Log: #189924 - find/search in projects does not look into include path
Apparently fixed, let's wait for feedback (IMHO it could be quite negative for those who have _big_ Include Path).