This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 161729 - I18N: filter xml files are not in l10n-kit
Summary: I18N: filter xml files are not in l10n-kit
Status: RESOLVED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Tomas Hurka
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2009-04-02 07:01 UTC by Masaki Katakai
Modified: 2009-04-08 20:03 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2009-04-02 07:01:20 UTC
It looks the location of these xml files have been changed in 6.7 and
now bundled in nbms. So these are not extracted into l10n-kit now.

profiler3/org-netbeans-modules-profiler.nbm/netbeans/config/Services/filters-default.xml
 -> profiler3/profiler/profiler/org/netbeans/modules/profiler/filters-default.xml

profiler3/org-netbeans-modules-profiler.nbm/netbeans/config/Services/filtersets-default.xml
 -> profiler3/profiler/profiler/org/netbeans/modules/profiler/filtersets-default.xml

I think we need to update l10n.patters under nbbuild.
Could you update it?

Btw, how about "oqlqueries-default.xml"? Do we need to localize it?

% diff -r af5f84db7290 nbbuild/l10n.patterns
--- a/nbbuild/l10n.patterns	Wed Mar 18 00:36:57 2009 +0100
+++ b/nbbuild/l10n.patterns	Thu Apr 02 14:51:46 2009 +0900
@@ -19,8 +19,9 @@
 **/docs/GUIExamplesDescription.html:
 **/org-netbeans-modules-apisupport-ant.jar:org/netbeans/modules/apisupport/ant/TemplateNames.properties
 **/modules/ext/debugger.html:
-profiler*/**/config/Services/filtersets-default.xml:
-profiler*/**/config/Services/filters-default.xml:
+**/*.jar:**/filtersets-default.xml:
+**/*.jar:**/filters-default.xml:
+**/*.jar:**/heapwalk/oqlqueries-default.xml:
 exclude **/*.jar:**/Bundle_noi18n.properties
 exclude **/batik-mod.jar:
 exclude **/json-*.jar:
%
Comment 1 Tomas Hurka 2009-04-02 13:35:17 UTC
Thanks for the patch. 
Comment 2 Tomas Hurka 2009-04-02 13:36:13 UTC
Fixed in profiler-main
changeset:   124506:985843000599
user:        Tomas Hurka <thurka@netbeans.org>
date:        Thu Apr 02 14:33:54 2009 +0200
summary:     bugfix #161729, filtersets-default.xml filters-default.xml and oqlqueries-default.xml files are not in l10n-kit

Comment 3 Quality Engineering 2009-04-08 07:50:08 UTC
Integrated into 'main-golden', will be available in build *200904080201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/985843000599
User: Tomas Hurka <thurka@netbeans.org>
Log: bugfix #161729, filtersets-default.xml filters-default.xml and oqlqueries-default.xml files are not in l10n-kit
Comment 4 Quality Engineering 2009-04-08 20:03:28 UTC
Integrated into 'main-golden', will be available in build *200904081400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/985843000599
User: Tomas Hurka <thurka@netbeans.org>
Log: bugfix #161729, filtersets-default.xml filters-default.xml and oqlqueries-default.xml files are not in l10n-kit