You need to log in before you can comment on or make changes to this bug.
If revision number is specified in status labels the performance will be bad as getting the revision number for each file will require exec'ing a hg call.
Created an attachment (id=54983) [details] Proposed patch
Ignore patch this was for bug 124887
Created an attachment (id=55161) [details] Proposed warning patch
The patch does not solve the problem, but at least warns the user if they add {revision} to the Mercurial Status Labels in the Options panel that there may be a serious performance penalty when viewing Mercurial controlled Projects and suggests they use Show Annotations or Show History instead. We need to see if there is some way to cache the revision information in the FileStatusCache so we can reuse it and avoid this performance penalty
IDE:------------------------------------------------- IDE: [16/01/08 17:51] Committing started Checking in options/MercurialPanel.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/options/MercurialPanel.java,v <-- MercurialPanel.java new revision: 1.9; previous revision: 1.8 done Checking in options/Bundle.properties; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/options/Bundle.properties,v <-- Bundle.properties new revision: 1.9; previous revision: 1.8 done Checking in MercurialAnnotator.java; /shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/MercurialAnnotator.java,v <-- MercurialAnnotator.java new revision: 1.20; previous revision: 1.19 done IDE: [16/01/08 17:51] Committing finished IDE: [16/01/08 17:51] Diffing finished IDE: [16/01/08 17:51] Diffing finished
Note that currently HgCommand.getLastRevision in formatAnnotation in MercurialAnnotator.java is called in AWT thread. This should be fixed as part of this bug.
Mercurial revision applies to the repository, not to an individual file. Therefore it makes little sense to support revision labels on individual files. Information as to which changesets a file changed in is available via Search History.
Created an attachment (id=62118) [details] main_81556_f3e5103db2a7-remove-revisionlabel-support.patch
Removed revision label support. changeset: 81867:d8c7649375ba tag: tip user: jrice@netbeans.org date: Thu May 29 13:13:21 2008 +0200 summary: #124895: Remove revision label support, not useful for mercurial repos and performance hit
Integrated into 'main-golden', available in NB_Trunk_Production #234 build Changeset: http://hg.netbeans.org/main/rev/d8c7649375ba User: jrice@netbeans.org Log: #124895: Remove revision label support, not useful for mercurial repos and performance hit
