Bug 123593 – Redundent forceStatusRefresh() call in Revert Modifications

HOME \ Community

Bug 123593 - Redundent forceStatusRefresh() call in Revert Modifications

Summary:

Redundent forceStatusRefresh() call in Revert Modifications

Status:	RESOLVED FIXED

Product:	versioncontrol
Component:	Mercurial
Version:	6.1
Platform:	All All

Priority:	P3 (vote)
Target Milestone:	6.1
Assigned To:	issues@versioncontrol
QA Contact:	issues@versioncontrol

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-12-06 20:21 by John Rice
Modified:	2008-01-03 09:34 (History)

Issue Type:	DEFECT
Exception Reporter :

Attachments
Proposed patch (1.03 KB, text/plain) 2007-12-06 20:22, John Rice	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From John Rice 2007-12-06 20:21:11

We are making a call to forceStatusRefresh() which is no longer required as we
immediately call
org.openide.filesystems.FileSystem.refresh() which in turns triggers the
MercurialInterceptor.fileChangedImpl() that
results in a call to forceStatusRefresh().

This should be removed, but was deemed to high a risk for release60 refresh, as
we'd need to test all of the possible
change conditions on Revert to be sure it's safe to remove.

------- Comment #1 From John Rice 2007-12-06 20:22:42 -------

Created an attachment (id=53964) [details]
Proposed patch

------- Comment #2 From John Rice 2007-12-21 11:45:51 -------

IDE:-------------------------------------------------
IDE: [21/12/07 11:45] Committing started
Checking in RevertModificationsAction.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/update/RevertModificationsAction.java,v
 <--  RevertModificationsAction.java
new revision: 1.8; previous revision: 1.7
done
IDE: [21/12/07 11:45] Committing finished