cornercorner
FeaturesPluginsDocs & SupportCommunityPartners

Bug 119442 - Refactor from within "Files" view should be improved.
: Refactor from within "Files" view should be improved.
Status: VERIFIED FIXED
: versioncontrol
Mercurial
: 6.1
: All All
: P3 (vote)
: 6.1
Assigned To:
:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2007-10-19 09:15 by
Modified: 2008-01-03 09:39 (History)
Issue Type: DEFECT
:


Attachments
proposed patch (2.61 KB, patch)
2007-10-22 18:54, Padraig Obriain
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2007-10-19 09:15:02
Product Version: NetBeans IDE 6.0 Beta 2 (Build 200710181000)
Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b05
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)
Userdir: D:\ide\60beta\user

Steps:
1. Open project under hg control and invoke "Mercurial | Status" action on it. 
2. Switch to "Files" view.
3. Select package and invoke "Refactor | Rename" action ... enter valid name
for it.

Appears as if in File view the copy worked but the deletion did not. You can
hit Update All in Status window to see the
new copy and commit this file, but you'd need to go and delete the old file
yourself.

Looks like the issue is that in File View we are trying to do a hg rename on a
directory which means nothing to hg and
so this fails, causing the deletion of the contained files not to be carried
out.
------- Comment #1 From 2007-10-22 18:51:10 -------
The problem is not that the hg rename but that we interpret the output as a
failure. In fact, the command succeeds.
------- Comment #2 From 2007-10-22 18:54:04 -------
Created an attachment (id=51428) [details]
proposed patch
------- Comment #3 From 2007-10-22 18:55:48 -------
IDE:-------------------------------------------------
IDE: [10/22/07 6:55 PM] Committing started
Checking in MercurialInterceptor.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/MercurialInterceptor.java,v 
<--  MercurialInterceptor.java
new revision: 1.8; previous revision: 1.7
done
Checking in util/HgCommand.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/util/HgCommand.java,v
 <-- 
HgCommand.java
new revision: 1.47; previous revision: 1.46
done
IDE: [10/22/07 6:55 PM] Committing finished
------- Comment #4 From 2007-11-16 13:16:08 -------
Verified.