This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 271419

Summary:	Storage of the patch file el3_0_4.diff for code donation (Using in creation of el-impl.jar)
Product:	javaee	Reporter:	vkprabha
Component:	Expression Language	Assignee:	Martin Fousek <marfous>
Status:	NEW ---
Severity:	normal
Priority:	P3
Version:	Dev
Hardware:	PC
OS:	Windows 7
Issue Type:	ENHANCEMENT	Exception Reporter:
Attachments:	Patch file is using to create el-impl.jar

Description vkprabha 2017-09-01 09:48:05 UTC

Created attachment 165069 [details]
Patch file is using to create el-impl.jar

The following patch files removed from code donation branch
1. el3_0_4.diff 
2. el2_2_3.diff

The latest patch file (el3_0_4.diff) is added in attachment of bug details.
The patch file is used for creation of patched el-impl.jar.

Steps for creation of the patched el-impl.jar:
1. checkout the EL project from http://java.net/projects/el-spec/sources
2. apply the patch over the sources - the patch must correspond with the downloaded version:
{PATH_TO_THE_REPOSITORY}/el-spec~source-code$ patch -p0 < {COMPLETE_HG_REPO}/libs.elimpl/patches/el3_0_4.diff
3. build the Expression Language project
4. from the JAR remove the public API - classes of the 'javax.' package

Comment 1 vkprabha 2017-09-01 10:03:11 UTC

Steps for creation of the patched el-impl.jar:
1. checkout the EL project from http://java.net/projects/el-spec/sources
2. Download the patch file 'el3_0_4.diff' 
3. Store the patch file 'el3_0_4.diff' at location {COMPLETE_HG_REPO}/libs.elimpl/patches/
4. apply the patch over the sources - the patch must correspond with the downloaded version:
{PATH_TO_THE_REPOSITORY}/el-spec~source-code$ patch -p0 < {COMPLETE_HG_REPO}/libs.elimpl/patches/el3_0_4.diff
5. build the Expression Language project
6. from the JAR remove the public API - classes of the 'javax.' package

Comment 2 Reema 2017-09-05 10:05:33 UTC

We should consider merging the patch to el-spec codebase  https://github.com/javaee/el-spec

For that we need information on the exact bugfixes that have gone in this patch.

Comment 3 vkprabha 2017-09-05 10:35:31 UTC

Following bugs are fixed with attached patch file:
1. #228038 - String concatenation expression marked as error: updated EL library
2. Bundled el-impl.jar is built by JDK6
3. #201414 - nb701/java 7 -- cannot compile jsp pages: updated remaining JARs
4. Added support for offsets in EL parser
5. Library for Expression Language implementation, friends with web.jsf.editor

(In reply to Reema from comment #2)
> We should consider merging the patch to el-spec codebase 
> https://github.com/javaee/el-spec
> 
> For that we need information on the exact bugfixes that have gone in this
> patch.