This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246546

Summary:	DataObject's internal fields are horribly guarded against race conditions
Product:	platform	Reporter:	Jaroslav Tulach <jtulach>
Component:	Data Systems	Assignee:	Jaroslav Tulach <jtulach>
Status:	RESOLVED FIXED
Severity:	normal	CC:	issues, jhavlin
Priority:	P2
Version:	8.1
Hardware:	PC
OS:	Linux
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	246127, 246672

Description Jaroslav Tulach 2014-08-19 11:42:07 UTC

Alexander discovered in bug 246127 that the modif field in DataObject is horribly synchronized. After looking at the class, I can only agree and straighten the observation: almost all fields in DataObject are not suited for mutual thread access. Probably result of DataObject being own of my first class written in Java...

Comment 1 Jaroslav Tulach 2014-08-19 11:42:47 UTC

I'll consolidate the locks a bit.

Comment 2 Jaroslav Tulach 2014-08-19 12:18:18 UTC

Please review
http://hg.netbeans.org/ergonomics/rev/fe1bbb185440
openide.loaders tests seem to pass OK.

Comment 3 Quality Engineering 2014-08-22 02:33:05 UTC

Integrated into 'main-silver', will be available in build *201408220001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/fe1bbb185440
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #246546: Tighten up synchronization when accessing DataObject instance fields