This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | regression: broken Toggle Comment | ||
---|---|---|---|
Product: | editor | Reporter: | Vladimir Voskresensky <vv159170> |
Component: | Actions/Menu/Toolbar | Assignee: | Dusan Balek <dbalek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | markiewb, ralphbenjamin |
Priority: | P1 | ||
Version: | 7.2 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Vladimir Voskresensky
2014-05-21 04:38:59 UTC
Looks like the side effect of http://hg.netbeans.org/main-silver/rev/7f2af9990520 Please, backout this change. It modifies behavior too much. I can not comment out functions which have line comments: void foo() [ // comment int a = 10; } It became: //void foo() [ comment // int a = 10; //} Perhaps only the line comments starting at line beginnings should be removed by the Toggle Comment Action. Vladimir, would it work for you as a sufficient tradeoff between the old behavior and the behavior requested by #168430? Thanks. (In reply to Dusan Balek from comment #3) > Perhaps only the line comments starting at line beginnings should be removed > by the Toggle Comment Action. Vladimir, would it work for you as a > sufficient tradeoff between the old behavior and the behavior requested by > #168430? Thanks. Are we sure the requested behavior in #168430 is something that we want? Personally I really do not like the proposed behavior and would probably be very annoyed when this hits the next release. If this has to be implemented, please make it configurable with a default for the old behavior. Thanks! (In reply to Dusan Balek from comment #3) > Perhaps only the line comments starting at line beginnings should be removed > by the Toggle Comment Action. Vladimir, would it work for you as a > sufficient tradeoff between the old behavior and the behavior requested by > #168430? Thanks. I think it will not work, because of the case #1: //<editor-fold defaultstate="collapsed" desc="foo"> void foo() { .... } //</editor-fold> when I have collapsed fold and would like to comment out whole content I just pressed Ctrl+/ but folding marker has leading "//" => it must not be erased OK - patch for #168430 reverted. http://hg.netbeans.org/jet-main/rev/c6ed70327131 thank you! Integrated into 'main-silver', will be available in build *201405280001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/c6ed70327131 User: Dusan Balek <dbalek@netbeans.org> Log: Issue #244615 - regression: broken Toggle Comment - fixed. Patch for ##168430 reverted. |