This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 243956

Summary:	Session change doesn't update Breakpoints tab
Product:	debugger	Reporter:	soldatov <soldatov>
Component:	Code	Assignee:	Martin Entlicher <mentlicher>
Status:	RESOLVED FIXED
Severity:	normal	CC:	henk89, issues
Priority:	P1
Version:	8.0.1
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Patch for updating the Breakpoints View after changing sessions Additional patch for updating the Breakpoints View after changing sessions

Description soldatov 2014-04-21 08:44:11 UTC

Scenario:
- Create Arguments sample (select GNU toolchain)
- Push Step into
- Set line breakpoint in args.c
- Create Welcome project (select GNU toolchain too)
- Push Step into
- Set line breakpoint in welcome.cc
- Check Breakpoints tab
===>
args.c:40	[33] welcome_2	
welcome.cc:38	[33] welcome_2
- Open Sessions tab
- Select "argument_1" session, call context menu and select "Make Current" menu item
- Check Breakpoints tab
==>
Real: I see old values
Expected:
args.c:40	[29992] argument_1	
welcome.cc:38	[29992] argument_1

Other scenario can be found in CR 18527756.

Comment 1 henk89 2014-07-25 15:10:33 UTC

Created attachment 148328 [details]
Patch for updating the Breakpoints View after changing sessions

Comment 2 henk89 2014-07-25 15:11:57 UTC

It should be fixed in the debugger core.
Please verify the patch attached.

Comment 3 Martin Entlicher 2014-07-25 15:21:00 UTC

O.K., I'll apply the patch.

Comment 4 Martin Entlicher 2014-07-29 16:41:05 UTC

The patch is applied:
http://hg.netbeans.org/core-main/rev/c5112353c0d6

Comment 5 Quality Engineering 2014-07-31 09:00:15 UTC

Integrated into 'main-silver', will be available in build *201407310738* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c5112353c0d6
User: mentlicher@netbeans.org
Log: #243956: Refresh breakpoints when they fire PROP_CURRENT_SESSION property change.

Comment 6 henk89 2014-08-01 09:19:00 UTC

Created attachment 148466 [details]
Additional patch for updating the Breakpoints View after changing sessions

The first patch was insufficient to fix the problem.

I'm not sure about deleting
"if (! (evt.getSource () instanceof Breakpoint)) return;"

Maybe we should add checking if evt.getSource() is instance of DebuggerManager instead.

Comment 7 Martin Entlicher 2014-08-01 10:40:33 UTC

I've moved the test of property name before the condition.
The modified new patch is applied to trunk:
http://hg.netbeans.org/core-main/rev/f703dfaa9a48
and I've verified it's behavior on a fix of issue #129354.

Please verify that it works for you in trunk and if so, we need to follow http://wiki.netbeans.org/NetBeans_80_HighResistance to get it into 8.0.1.

Comment 8 Quality Engineering 2014-08-02 05:08:00 UTC

Integrated into 'main-silver', will be available in build *201408020001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/f703dfaa9a48
User: mentlicher@netbeans.org
Log: #243956: Listen on current session changes and refresh breakpoints. This assures that session-speficic properties are updated.

Comment 9 henk89 2014-08-04 14:17:41 UTC

(In reply to Martin Entlicher from comment #7)
> I've moved the test of property name before the condition.
> The modified new patch is applied to trunk:
> http://hg.netbeans.org/core-main/rev/f703dfaa9a48
> and I've verified it's behavior on a fix of issue #129354.
> 
> Please verify that it works for you in trunk and if so, we need to follow
> http://wiki.netbeans.org/NetBeans_80_HighResistance to get it into 8.0.1.

It works fine for my test case in trunk.

Comment 10 Martin Entlicher 2014-08-06 11:36:36 UTC

Thanks for verification, upgrading to P1 and going integrate to release 8.0.1.

Comment 11 Martin Entlicher 2014-08-06 12:15:04 UTC

Backported to release801:
http://hg.netbeans.org/releases/rev/4e0aca5ec734

Comment 12 Quality Engineering 2014-08-07 14:47:45 UTC

Integrated into 'releases/release801', will be available in build *201408071314* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/4e0aca5ec734
User: mentlicher@netbeans.org
Log: #243956: Listen on current session changes and refresh breakpoints. This assures that session-speficic properties are updated.
(transplanted from f703dfaa9a4848f8717abf57cd1d36b0a080210d)