This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: [Options] labels manual proxy should be disabled too | ||
---|---|---|---|
Product: | platform | Reporter: | markiewb |
Component: | Options&Settings | Assignee: | Theofanis Oikonomou <theofanis> |
Status: | VERIFIED FIXED | ||
Severity: | normal | Keywords: | PATCH_AVAILABLE |
Priority: | P3 | ||
Version: | 7.4 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Shows the issue
Proposed patch |
Description
markiewb
2013-06-18 14:01:20 UTC
Created attachment 135972 [details]
Shows the issue
Created attachment 136042 [details]
Proposed patch
I like to propose a patch to solve this issue. The patch
* enables/disables labels of the manual proxy controls regarding to the checked state of its radio button
* adds missing mnemonics for several labels
* adds usability when checking the manual proxy radio button: the hostname control is focused after selecting the radio button (the user chooses the mode and can type immediately)
@NB-Dev: Please review and commit if appropriate.
Thank you for the patch. P3 due to mnemonics. I found more cases of such behavior and I am not aware if there is a common practice for this. I think that the correct behavior should be to disable also the labels though. Fixed: http://hg.netbeans.org/core-main/rev/c26aa1a9617d Integrated into 'main-silver', will be available in build *201306272300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/c26aa1a9617d User: Theofanis Oikonomou <theofanis@netbeans.org> Log: #231448 - Patch for: [Options] labels manual proxy should be disabled too Verified in 201307011244 |