This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 226366

Summary: Patch for: Separators in SVN/HG option panels should resize properly
Product: versioncontrol Reporter: markiewb
Component: CodeAssignee: Ondrej Vrabec <ovrabec>
Status: VERIFIED FIXED    
Severity: normal Keywords: NETFIX, PATCH_AVAILABLE
Priority: P4    
Version: 7.3   
Hardware: PC   
OS: Windows 7   
Issue Type: DEFECT Exception Reporter:
Attachments: Shows the issue
Proposed patch
Patch in action

Description markiewb 2013-02-19 21:27:11 UTC
Created attachment 131584 [details]
Shows the issue

The option panels for SVN and HG use separators. These separators seem to have a fixed width thus the layout of the panels looks ugly (and not very professional IMHO) when resizing the options dialog. See screenshot.

EXPECTED: Separators should resize vertically and be attached to the right border of the panel.
Comment 1 markiewb 2013-02-25 22:35:45 UTC
Created attachment 131870 [details]
Proposed patch

I like to propose the following patch to solve the resizing issue. 

The patch 
* changes the anchors and alignment of labels/buttons/separators/checkboxes
* removes some artificial linebreaks in labels (which are not necessary IMHO)

The result can be seen in the following (to be attached screenshot).

@NB-Devs: Please review, discuss and commit. Thank you!
Comment 2 markiewb 2013-02-25 22:36:15 UTC
Created attachment 131871 [details]
Patch in action
Comment 3 Ondrej Vrabec 2013-02-26 09:15:51 UTC
Thanks for the patch, i'll tweak it a bit, currently there seem to be some small issues with large fonts (in Subversion panel not all labels are visible)
Comment 4 Ondrej Vrabec 2013-02-26 09:18:25 UTC
fix: http://hg.netbeans.org/core-main/rev/4bf7e73bc193
Comment 5 Quality Engineering 2013-02-27 16:12:22 UTC
Integrated into 'main-golden', will be available in build *201302270948* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/4bf7e73bc193
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #226366 - Patch for: Separators in SVN/HG option panels should resize properly
Comment 6 markiewb 2013-07-23 21:57:55 UTC
Verified in 201307222300