This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: Add quicksearch for projects | ||
---|---|---|---|
Product: | platform | Reporter: | markiewb |
Component: | Quick Search | Assignee: | Jaroslav Havlin <jhavlin> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | mkleint |
Priority: | P3 | Keywords: | NETFIX, PATCH_AVAILABLE |
Version: | 7.3 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
Patch
Patch in action |
Description
markiewb
2013-01-02 12:04:16 UTC
Created attachment 129814 [details]
Patch
I like to propose the following patch.
It adds a quicksearch provider which iterates over all project names. It uses the non-exported ProjectUtilities class, so i could not create a 3rd-party plugin.
@NetBeans-Devs: Please review, discuss and commit. Thank you.
Created attachment 129815 [details]
Patch in action
Advise from Jaroslav: Dne St 2. ledna 2013 13:30:47, Benno Markiewicz napsal(a): > [Resolved] Thank you for your time and help. > > It was an experiment to create a 3rd-party module for > http://netbeans.org/bugzilla/show_bug.cgi?id=224378. > Because I cannot access the org.netbeans.modules.project.ui.ProjectUtilities > from my own module, I decided to propose a patch for "projectui". See the > link above for the patch, if interested. Another option (that does not make projectui dependencies heavier) would be to add method select(Project p) into http://bits.netbeans.org/dev/javadoc/org-netbeans-modules- projectuiapi/org/netbeans/api/project/ui/OpenProjects.html and keep the integration in own module. (In reply to comment #3) > Another option (that does not make projectui dependencies heavier) would be to > add method select(Project p) into > http://bits.netbeans.org/dev/javadoc/org-netbeans-modules- > projectuiapi/org/netbeans/api/project/ui/OpenProjects.html > and keep the integration in own module. The API change seems reasonable to me. Milos, can you please evaluate the options? Thanks. (In reply to comment #4) > (In reply to comment #3) > > Another option (that does not make projectui dependencies heavier) would be to > > add method select(Project p) into > > http://bits.netbeans.org/dev/javadoc/org-netbeans-modules- > > projectuiapi/org/netbeans/api/project/ui/OpenProjects.html > > and keep the integration in own module. > The API change seems reasonable to me. Milos, can you please evaluate the > options? Thanks. I'd rather keep the selection out of the API. So I suggest we integrate it as part of projectui module. (In reply to comment #5) > > Milos, can you please evaluate the options? > I'd rather keep the selection out of the API. > So I suggest we integrate it as part of projectui module. OK, it's fine by me. Thank you. Integrated as http://hg.netbeans.org/core-main/rev/246f4a6a1fab Thank you for providing the patch, Benno. Verified in 201307011244 |