This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Inspect and Transform report complete when still working | ||
---|---|---|---|
Product: | editor | Reporter: | javydreamercsw <javydreamercsw> |
Component: | Refactoring | Assignee: | Ralph Ruijs <ralphbenjamin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, jlahoda |
Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
Version: | 7.3 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Proposed API change |
Description
javydreamercsw
2012-11-01 21:23:46 UTC
I am not quite sure if I understood the report properly, but seems to me that it relates to the progress bar shown after pressing "Do Refactoring". This progress bar appears in "Refactoring..." dialog. Sorry Ralph, but I put a breakpoint into RefactoringSession.doRefactoring at the beginning of the first finally section. And I see that the progress bar already is at 100% at that point, while a lot of (almost all) of the work is still to be done (note that the RefactoringElementImplementation.performChange is often noop): -committing of the RefactoringCommits -saving files -performing file changes So I think this will need to be fixed in the RefactoringSession. (In reply to comment #1) > I am not quite sure if I understood the report properly, but seems to me that > it relates to the progress bar shown after pressing "Do Refactoring". This > progress bar appears in "Refactoring..." dialog. Yes, that's exactly what I meant. > > Sorry Ralph, but I put a breakpoint into RefactoringSession.doRefactoring at > the beginning of the first finally section. And I see that the progress bar > already is at 100% at that point, while a lot of (almost all) of the work is > still to be done (note that the RefactoringElementImplementation.performChange > is often noop): > -committing of the RefactoringCommits > -saving files > -performing file changes > > So I think this will need to be fixed in the RefactoringSession. Created attachment 128039 [details]
Proposed API change
This patch changes RefactoringCommit to implement the ProgressProvider interface.
Please review. Changeset: 61c15968923c Author: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Date: 2012-11-28 13:54 Integrated into 'main-golden', will be available in build *201211300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/61c15968923c User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Log: Issue #221295 - Inspect and Transform report complete when still working |