This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: Debugger: Add action and shortcut - "enable/disable line breakpoint" | ||
---|---|---|---|
Product: | debugger | Reporter: | markiewb |
Component: | Code | Assignee: | Martin Entlicher <mentlicher> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | mkrauskopf, mmirilovic |
Priority: | P3 | Keywords: | PATCH_AVAILABLE |
Version: | 7.3 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
patch for api.debugger
patch for debugger.jpda.ui patch for spi.debugger.ui Screenshot showing the action in the menu/contextmenu |
Description
markiewb
2012-09-25 05:13:14 UTC
Created attachment 125732 [details]
patch for api.debugger
Created attachment 125733 [details]
patch for debugger.jpda.ui
Created attachment 125734 [details]
patch for spi.debugger.ui
Created attachment 125735 [details]
Screenshot showing the action in the menu/contextmenu
I want to contribute a patch for the requested feature.
I had to change
* api.debugger
* spi.debugger.ui
* debugger.jpda.ui
The patch adds a new action, which toggles the enabled state of a {@link LineBreakpoint}.
If the breakpoint is enabled, then it will be disabled.
If the breakpoint is disabled, then it will be enabled.
If the breakpoint does not exist, then it be created.
Result - see screenshot
The implementation was easy. The main code is based on {@link ToggleBreakpointActionProvider}, the rest is only registering stuff.
@NetBeans-Dev: Please review, discuss and commit the patch.
Is it really necessary to add yet another action to the menu? I think it's too long already now. Can't the shortcut be bound with the "Breakpoint > Enabled" popup menu action in Editor gutter? (In reply to comment #5) > Can't the shortcut be bound with the "Breakpoint > Enabled" > popup menu action in Editor gutter? Yes, why not. Alternative 1: Register a shortcut for the org.netbeans.modules.debugger.ui.actions.BreakpointEnableAction. But the shortcut/action did not work. I think because it is not a standard action, but a ContextAwareAction. Help from the component owner is appreciated. Alternative 2: Add the action from the patch, but remove the menu registration. This way the action is still available for assigning a shortcut. Martine, what are your thoughts on this? BTW, in the latter case I am afraid that discover-ability would suffer. *** Bug 156152 has been marked as a duplicate of this bug. *** @Martin: Any change to get the patch(es) integrated into 7.4? (In reply to comment #9) > @Martin: Any change to get the patch(es) integrated into 7.4? Bump. @Martin: Any chance to get the patch(es) integrated into 7.4? You could also ALT-Mouseclick on the annotation icon in the left editor gutter to enable/disable the breakpoint. (Read about this approach used in IDEA) (In reply to markiewb from comment #11) > You could also ALT-Mouseclick on the annotation icon in the left editor > gutter to enable/disable the breakpoint. (Read about this approach used in > IDEA) Related to https://netbeans.org/bugzilla/show_bug.cgi?id=169116 Resolving as worksforme. I provided a plugin for this issue myself. http://plugins.netbeans.org/plugin/67859/?show=true |