This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | GlassFish 3.1.2.2 not recognized by IDE | ||
---|---|---|---|
Product: | serverplugins | Reporter: | Jiri Skrivanek <jskrivanek> |
Component: | GlassFish | Assignee: | TomasKraus |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | jrechtacek, mmirilovic, musilt2, pjiricka, TomasKraus |
Priority: | P1 | ||
Version: | 7.2 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
incomplete patch
a shorter patch final patch |
Description
Jiri Skrivanek
2012-07-02 10:43:50 UTC
Created attachment 121648 [details]
incomplete patch
This patch solves the registration issue. I don't know the direct download URL and who is responsible for indirect download URL. I'm also not sure about display name.
Just for the record: To solve this and other potential issues we need the _final_ build of GF and _final_ download location. Created attachment 121664 [details]
a shorter patch
This patch is a bit shorter. It still doesn't have the corrected fallback download URL... waiting on final decision from GF website folks...
(In reply to comment #3) > Created attachment 121664 [details] > a shorter patch > > This patch is a bit shorter. It still doesn't have the corrected fallback > download URL... waiting on final decision from GF website folks... Nice! Thanks Vince. Can, you little bit explain direct/indirect URLs? Is the indirect URL (text file on netbeans.org) a place where the updated download location should be placed? I guess we should treat 3.1.2 patch 2 as just a 3.1.2. What is your opinion? I guess this is what you are trying to make clear in discussion with GF folks. Right? (In reply to comment #4) > > Can, you little bit explain direct/indirect URLs? The code for 'download now' uses the following strategy to determine which bits to download: 1. Use the indirect URL (the one pointed to NB.org) to get the partial URL of the download zip file. NB then creates a complete URL and downloads that zip file. 2. If the first strategy fails because nb.org is down, the complete, hardcoded, url (the direct URL), is used to attempt to download the zip file to support the download now feature. Peter Williams did the impl on this, since we assumed that there would be situations where the URL to access GF bits would be changed at odd points in the release schedule for NB. > Is the indirect URL (text > file on netbeans.org) a place where the updated download location should be > placed? Yes. >I guess we should treat 3.1.2 patch 2 as just a 3.1.2. What is your > opinion? That is my opinion. Making 3.1.2 and 3.1.2.2 'visible' to users seems bad... especially in NB, since 3.1.2 is so broken. > > I guess this is what you are trying to make clear in discussion with GF folks. > Right? yes. Created attachment 121703 [details]
final patch
this should just about do it for code changes.
I will update the content of the indirect URL when the bits for 3.1.2.2 are fully live. It points to 3.1.2 right now.
please shepherd this through verification and commitment into releases/release72 Integrated into 'main-golden', will be available in build *201207040002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/2144af0ac5f2 User: vince kraemer <vkraemer@netbeans.org> Log: #215061: 3.1.2.2 registration and download now support Verified with exceptions in dev build 201207040002: - registration of 3.1.2.2 server works - direct URL to 3.1.2.2 is not yet valid - not clear whether version 3.1.2.1-SNAPSHOT (build 3) bundled in installer is final Pushed to release72 as 094e5c470ff4. Integrated into 'releases', will be available in build *201207092359* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/094e5c470ff4 User: vince kraemer <vkraemer@netbeans.org> Log: #215061: 3.1.2.2 registration and download now support Verified in NetBeans IDE 7.2 (Build 201207092359): - installer contains GlassFish Server Open Source Edition 3.1.2.2 (build 4) - registration of 3.1.2.2 server works - direct URL to 3.1.2.2 is not yet valid It is possible to add server but first you must show folder of glassfish 3.1.2 or prior and netbeans will register it, then just copy to that folder content of glassfish 3.1.2.2, it will just work (In reply to comment #14) > It is possible to add server but first you must show folder of glassfish 3.1.2 > or prior and netbeans will register it, then just copy to that folder content > of glassfish 3.1.2.2, it will just work Which build of IDE did you use? (Attach your messages.log is the best) Thanks (In reply to comment #14) > It is possible to add server but first you must show folder of glassfish 3.1.2 > or prior and netbeans will register it, then just copy to that folder content > of glassfish 3.1.2.2, it will just work There is one simpler workaround. Just change the name of the jar in glassfish installation (c:\glassfish3\glassfish\lib\install\applications\__admingui\WEB-INF\lib\console-core-3.1.2.jar) Then our server 3.1.2.x will be recognized by the netbeans as version 3.1.2 ;-) Works fine. |