This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Support disabling of 'quick search' in property sheet | ||
---|---|---|---|
Product: | platform | Reporter: | tomwheeler <tomwheeler> |
Component: | Explorer | Assignee: | apireviews <apireviews> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | API_REVIEW_FAST |
Priority: | P3 | ||
Version: | 7.1 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: | Patch to support disabling quick search on property sheets. |
Description
tomwheeler
2011-06-10 19:52:40 UTC
Created attachment 108850 [details]
Patch to support disabling quick search on property sheets.
I've added a patch which includes the change to disable quick search either globally or per-instance, along with related documentation and tests.
Good, I think you can integrate this. Y01 What is the usecase for the systemproperty? Is it really supposed to be private? If some application relies on it to work, then it does not look very private + maybe it would rather be a branding key. Y01: The use case for the system property is that it seemed a good way for one to disable quick search for all property sheets, including instances which are defined by the application and to which you otherwise have no access (i.e. the dialog shown by PropertiesAction or the TopComponent shown via the Window menu). You are right that it's not really a private system property since it's intended for use by application developers. I feel a system property is more flexible than a branding key, since it allows one to easily change behavior via the command line , the .conf file (e.g. -J-D option to the launcher) or at runtime (e.g. through an action that sets the system property). I think that "Under development" is probably the best value for the stability of the system property. Can you make this change when (if) you integrate or do you need me to submit a new patch? pushed to core-main in changeset 7d8ea9251fb6, with subsequent minor correction to arch.xml made in changeset aa386fc52625. updated again in changeset efa1f26e89af, since apichanges.xml tried to link to package private class and caused nbms-and-javadoc build #7404 to be unstable. Integrated into 'main-golden', will be available in build *201106190600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/7d8ea9251fb6 User: Thomas W. Wheeler <tomwheeler@netbeans.org> Log: #199349 - Support disabling of 'quick search' in property sheet Integrated into 'main-golden', will be available in build *201106200600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/efa1f26e89af User: Thomas W. Wheeler <tomwheeler@netbeans.org> Log: #199349: don't link to package-private class Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/1fdf22a20e37 User: Thomas W. Wheeler <tomwheeler@netbeans.org> Log: #199349: removing @Test annotations per Jesse's suggestion |