This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 197416

Summary:	org.netbeans.modules.csl.navigation.ElementNode.updateRecursively slow in AWT EDT
Product:	editor	Reporter:	David Konecny <dkonecny>
Component:	CSL (API & infrastructure)	Assignee:	David Strupl <dstrupl>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andyr123, cjoasis, mfukala, pjiricka, tprochazka
Priority:	P3	Keywords:	PERFORMANCE
Version:	7.0
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:	165940
Attachments:	nps snapshot

Description David Konecny 2011-04-05 01:15:17 UTC

Build: NetBeans IDE Dev (Build 20110405-a4b37e9a209d)
VM: Java HotSpot(TM) 64-Bit Server VM, 19.1-b02, Java(TM) SE Runtime Environment, 1.6.0_24-b07
OS: Linux

User Comments:
GUEST: 3rd in a row and getting worse

dkonecny: I had large HTML file opened in IDE (2MB) and suddenly everything froze for very long time.

tprochazka: Netbeans often freeze very long time during debugging

GUEST: Opened a 300 kilobyte YAML file.

GUEST: debugging and waited 44sec for this msgbox to appear



Maximum slowness yet reported was 55600 ms, average is 31902

Comment 1 David Konecny 2011-04-05 01:15:32 UTC

Created attachment 107494 [details]
nps snapshot

Comment 2 David Konecny 2011-04-05 01:23:53 UTC

Whenever IDE is frozen while editing my big HTML file I can see in threaddump:

org.netbeans.modules.csl.navigation.ElementNode.updateRecursively(ElementNode.java:298)

I wonder whether it could be optimized? My navigation window is not even opened - it is in collapsed mode. Opening it I can see thousands of nodes for my big HTML file. I guess in this case it is pretty much pointless to try to draw navigation window with all nodes from my HTML document. Should not there be some threshold after which we simply give creating Navigation window??

Comment 3 David Strupl 2011-04-05 16:21:09 UTC

> I wonder whether it could be optimized?

Just go ahead and attach a patch. I am ready to integrate any improvements into CSL before CSL gets real owner ...

Comment 4 David Strupl 2012-03-26 08:26:21 UTC

Changeset: 7bf99386501e
Author:    David Strupl <dstrupl@netbeans.org>
Date:      2012-03-26 10:17
Message:   CSL navigator: updateRecursively slow in AWT EDT --> moved out from AWT EDT. Let's see what is going to break.
Issue #197416 - org.netbeans.modules.csl.navigation.ElementNode.updateRecursively slow in AWT EDT

Comment 5 Quality Engineering 2012-03-27 17:00:42 UTC

Integrated into 'main-golden', will be available in build *201203271056* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7bf99386501e
User: David Strupl <dstrupl@netbeans.org>
Log: CSL navigator: updateRecursively slow in AWT EDT --> moved out from AWT EDT. Let's see what is going to break.
Issue #197416 - org.netbeans.modules.csl.navigation.ElementNode.updateRecursively slow in AWT EDT