# HG changeset patch
# Parent 9e9f8b3781fe8a7253ad5c146286633e3f1a69df
# User Jesse Glick <jglick@netbeans.org>
# Date 1374766451 14400

See FindBugs RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN.

diff --git a/maven/src/org/netbeans/modules/maven/api/Constants.java b/maven/src/org/netbeans/modules/maven/api/Constants.java
--- a/maven/src/org/netbeans/modules/maven/api/Constants.java
+++ b/maven/src/org/netbeans/modules/maven/api/Constants.java
@@ -90,7 +90,7 @@
      * allows to customize project's display name. The global equivalent is $userhome/Preferences/org/netbeans/modules/maven.properties' property of project.displayName
      */
     public static final String HINT_DISPLAY_NAME = "netbeans.hint.displayName";
-    
+
     /**
      * apache maven default groupid for maven plugins. 
      */ 
diff --git a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java
--- a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java
+++ b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java
@@ -81,8 +81,8 @@
         if (PluginPropertyUtils.getPluginVersion(nbmp.getMavenProject(), Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin") == null) {
             return true;
         }
-        Boolean toret = Boolean.valueOf(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null));
-        if (toret == Boolean.FALSE) {
+        boolean toret = Boolean.parseBoolean(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null));
+        if (!toret) {
             if (pr != null) {
                 pr.addReport(PROBLEM_REPORT);
             }